After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574059 - search button not available in some cases
search button not available in some cases
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 575135 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-03-04 12:59 UTC by Sebastien Bacher
Modified: 2009-03-12 20:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
test case (543 bytes, text/plain)
2009-03-04 16:11 UTC, Ignacio Casal Quinteiro (nacho)
  Details
Fixes the regression in GtkComboBoxEntry (2.10 KB, patch)
2009-03-04 19:29 UTC, Michael Hasselmann
none Details | Review
Fixes the regression in GtkComboBoxEntry (corrected diff) (1.47 KB, patch)
2009-03-04 19:39 UTC, Michael Hasselmann
committed Details | Review

Description Sebastien Bacher 2009-03-04 12:59:30 UTC
the bug has been opened on https://bugs.launchpad.net/bugs/337432

"gedit 2.25.8-0ubuntu1

http://launchpadlibrarian.net/23405841/Capture.png
Here is the screenshots of the bug. As said above, to reproduce the bug, one just have to press ctrl+f
same problem with search and replace. There is no bug while choosing the incremental search option from the search menu. It can be used as a workaround."
Comment 1 Sebastien Bacher 2009-03-04 13:00:00 UTC
the issue seems to be new in 2.25.8
Comment 2 jessevdk@gmail.com 2009-03-04 13:07:56 UTC
I cannot reproduce this on intrepid with gedit 2.25.8. The sensitivity of the button is controlled by gtk_dialog_set_response_sensitive, and is set to sensitive whenever text in the entry is changed and not empty. Can this be a gtk+ problem?
Comment 3 Sebastien Bacher 2009-03-04 13:29:44 UTC
could be, selecting something in the combo change the button correctly but typing text doesn't
Comment 4 Ignacio Casal Quinteiro (nacho) 2009-03-04 16:11:23 UTC
Created attachment 130030 [details]
test case

This seems a bug in gtk+, as you can see in the test case the changed signal is not emitted when you type on the combobox. With older versions of gtk+ this works perfect.
Comment 5 Ignacio Casal Quinteiro (nacho) 2009-03-04 16:55:07 UTC
I've fixed this in gedit by using the changed signal in the GtkEditable instead of using the comobobox directly.
Comment 6 Oxmosys 2009-03-04 18:34:29 UTC
I confirm that last commit works perfectly.

I also tried to do a git bisect and I can confirm that this regression didn't appear in gedit itself as previous revisions that worked correctly still have this bug when re-compiled.
Comment 7 Michael Hasselmann 2009-03-04 19:29:15 UTC
Created attachment 130055 [details] [review]
Fixes the regression in GtkComboBoxEntry

http://bugzilla.gnome.org/show_bug.cgi?id=572478 caused the regression in GtkComboBoxEntry's gtk_combo_box_entry_contents_changed()
Comment 8 Michael Hasselmann 2009-03-04 19:39:37 UTC
Created attachment 130057 [details] [review]
Fixes the regression in GtkComboBoxEntry (corrected diff)
Comment 9 Matthias Clasen 2009-03-10 15:49:22 UTC
Please commit. As this fixes a regression, I want it in 2.16.0
Comment 10 Ignacio Casal Quinteiro (nacho) 2009-03-12 20:42:19 UTC
*** Bug 575135 has been marked as a duplicate of this bug. ***