GNOME Bugzilla – Bug 574009
[mpegpsdemux] seeking broken for streams that don't start with timestamp 0
Last modified: 2009-03-12 09:39:22 UTC
Since commit c8eb591688cc64c3da68ef34729b2720fd94a99b "Add pull mode to mpegpsdemux", seeking within a MPEG PS file whose timestamps don't start at 0 doesn't work any more. This is a regression introduced with pull-mode, as it was fixed before in bug #557161. An example for such an MPEG file is a chapter cut directly from a VOB file without remuxing.
*** Bug 454228 has been marked as a duplicate of this bug. ***
If this is a regression, shouldn't it be a blocker?
Actually, there's many files we can't *START* playing with the new pull-mode.
Please could you provide a sample clip?
http://people.zoy.org/~sam/apple_promouse.mpeg
All these files :) http://gstreamer.freedesktop.org/data/media/incoming/Metallica - One.mpg http://gstreamer.freedesktop.org/data/media/incoming/mpeg_layer1_audio.mpg http://gstreamer.freedesktop.org/data/media/incoming/problematic/Aluminum_-_Perfect_Blue_-_Torn.mpg http://gstreamer.freedesktop.org/data/media/incoming/problematic/starfleet.mpg http://gstreamer.freedesktop.org/data/media/large/shihad.mpg http://gstreamer.freedesktop.org/data/media/medium/alien.mpg http://samples.mplayerhq.hu/A-codecs/MP3/mpeg_layer1_audio.mpg http://samples.mplayerhq.hu/archive/all/avi+mpeg2video+mp2++Rock_cut.mpg http://samples.mplayerhq.hu/archive/all/avi+mpeg4+aac++clip.mpg.xvid+aac.avi http://samples.mplayerhq.hu/archive/audio/aac/mov+h264+aac++mp4box_frag.mp4 http://samples.mplayerhq.hu/benchmark/testsuite1/matrixbench_vcd.mpg http://samples.mplayerhq.hu/ffmpeg-bugs/BHG_pickin_on_me.mpg http://samples.mplayerhq.hu/MPEG1/zelda first commercial.mpeg http://samples.mplayerhq.hu/MPEG-VOB/0423/FATAL/Choque.mpg http://samples.mplayerhq.hu/MPEG-VOB/0423/strange/dumbdog.mpg http://samples.mplayerhq.hu/MPEG-VOB/A-V_sync/Alien.mpg http://samples.mplayerhq.hu/MPEG-VOB/dallas.mpg http://samples.mplayerhq.hu/MPEG-VOB/eof.mpeg http://samples.mplayerhq.hu/MPEG-VOB/interlaced/twc-teme-svcd-sample.mpg http://samples.mplayerhq.hu/MPEG-VOB/JapAd.mpg http://samples.mplayerhq.hu/MPEG-VOB/PES/cica.mpeg http://samples.mplayerhq.hu/MPEG-VOB/PES/Einparken.mpg http://samples.mplayerhq.hu/MPEG-VOB/user_data_and_CC/akos-unknown_user_data_4D_50-gabucino.mpg
no need to test the non-mpeg files I gave above. I just grepped ('\.mp') for the list of files that have playbin regressions AND were available on public websites.
this patch seems to fix the issues, will re-run insanity on the failing files to make sure: https://core.fluendo.com/gstreamer/trac/changeset?old_path=trunk%2Fgst-fluendo-mpegdemux%2Fsrc&old=1599&new_path=trunk%2Fgst-fluendo-mpegdemux%2Fsrc&new=1599
commit bfdfc069aafccf7a207fd19e52707d7d3ff0ad79 Author: Josep Torra <n770galaxy@gmail.com> Date: Tue Mar 10 21:18:20 2009 +0100 mpegdemux: Fixed a bug in the TS scanner. Fixes #574009
It's fixed now for normal files, but not for files where the timestamps don't start at 0 (which was the original report). Seeking for those files is ok, but playback is very choppy/stuttery – I'll produce a sample clip. Should I open a new bug report for this problem?
Robin, that would be the other bug which I un-duplicated from this one : http://bugzilla.gnome.org/show_bug.cgi?id=454228