After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573884 - Seeking is different from Viewer or Ruler
Seeking is different from Viewer or Ruler
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.13.1
Assigned To: Alessandro Decina
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-03 09:22 UTC by Edward Hervey
Modified: 2009-03-03 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Edward Hervey 2009-03-03 09:22:09 UTC
When seeking from the Viewer, it sends a lot more seek requests than if you seek from the Ruler.

The Ruler seeking has a system to limit the seeks to a decent number. If you try to seek less than Xms after a previous seek, it will append it to a queue and seek to that position after the timeout.
Whereas the Ruler always sends out the seeks.

The real reason to this timeout is to make sure we give enough time for the decoded buffer to reach the sinks before sending out another seek which would abort the previous decoding (aka: we wasted cpu to decode a frame we never displayed).

Optimally, what we should do is send out the (pending) seek just after the previous frame succesfully reached the sink.

But in the meantime, we should make the Viewer have the same seeking behaviour as the Ruler, and maybe centralize that seeking code somewhere.
Comment 1 Alessandro Decina 2009-03-03 12:22:24 UTC
commit b4ac961512044d3929d08277f00648039cc878e5
Author: Alessandro Decina <alessandro.decina@collabora.co.uk>
Date:   Tue Mar 3 13:18:43 2009 +0100

    Add pitivi.utils.Seeker. Make ruler and viewer use it.