After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573830 - g_timeout_add_seconds should be preferred to g_timeout_add
g_timeout_add_seconds should be preferred to g_timeout_add
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.26.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[cleanup]
Depends on:
Blocks:
 
 
Reported: 2009-03-02 22:23 UTC by Marcel Stimberg
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
substitute g_timeout_add by g_timeout_add_seconds (9.68 KB, patch)
2009-03-02 22:25 UTC, Marcel Stimberg 		committed Details | Review

Description Marcel Stimberg 2009-03-02 22:23:11 UTC 
Please describe the problem:
According to https://wiki.ubuntu.com/SavingTheWorld (and of course according to the gtk docs) using g_timeout_add_seconds is preferred over g_timeout_add if a timeout in seconds is desired.



Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Patch is coming up...
Comment 1 Marcel Stimberg 2009-03-02 22:25:18 UTC 
Created attachment 129896 [details] [review]
substitute g_timeout_add by g_timeout_add_seconds

This patch substitutes calls like g_timeout_add(1000,...) with g_timeout_add_seconds(1,...) and therefore helps in saving the world ;-)
Comment 2 Matthew Barnes 2009-03-02 22:50:34 UTC 
Nice.  Approved for post-2.26.
Comment 3 André Klapper 2009-05-03 19:30:14 UTC 
Evo has branched, can this get in now?