After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573343 - Type mismatches in gstdirectdrawsink.c
Type mismatches in gstdirectdrawsink.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-27 01:58 UTC by LRN
Modified: 2009-02-27 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description LRN 2009-02-27 01:58:48 UTC
diff --git a/sys/directdraw/gstdirectdrawsink.c b/sys/directdraw/gstdirectdrawsink.c
index a128b31..eb09a82 100644
--- a/sys/directdraw/gstdirectdrawsink.c
+++ b/sys/directdraw/gstdirectdrawsink.c
@@ -610,7 +610,7 @@ gst_directdraw_sink_buffer_alloc (GstBaseSink * bsink, guint64 offset,
               !gst_directdraw_sink_surface_check (ddrawsink, surface))
           ) {
         gst_directdraw_sink_surface_destroy (ddrawsink, surface);
-        gst_buffer_unref (surface);
+        gst_buffer_unref (GST_BUFFER(surface));
         surface = NULL;
       } else {
         /* We found a suitable surface */
@@ -629,7 +629,7 @@ gst_directdraw_sink_buffer_alloc (GstBaseSink * bsink, guint64 offset,
     DDSURFACEDESC2 surface_desc;
     DDSURFACEDESC2 *sd;
 
-    if (!gst_structure_get_int (structure, "depth", &depth)) {
+    if (!gst_structure_get_int (structure, "depth", (gint *) &depth)) {
       GST_CAT_DEBUG_OBJECT (directdrawsink_debug, ddrawsink,
           "Can't get depth from buffer_alloc caps");
       return GST_FLOW_ERROR;
@@ -663,7 +663,7 @@ gst_directdraw_sink_buffer_alloc (GstBaseSink * bsink, guint64 offset,
           gint bpp, endianness, red_mask, green_mask, blue_mask;
 
           /* get new display mode properties */
-          gst_structure_get_int (display_structure, "depth", &depth);
+          gst_structure_get_int (display_structure, "depth", (gint *) &depth);
           gst_structure_get_int (display_structure, "bpp", &bpp);
           gst_structure_get_int (display_structure, "endianness", &endianness);
           gst_structure_get_int (display_structure, "red_mask", &red_mask);
@@ -997,7 +997,7 @@ gst_ddrawvideosink_get_format_from_caps (GstDirectDrawSink * ddrawsink,
       pPixelFormat->dwBBitMask = GUINT32_TO_BE (pPixelFormat->dwBBitMask);
     }
   } else if (gst_structure_has_name (structure, "video/x-raw-yuv")) {
-    gint fourcc;
+    guint32 fourcc;
 
     pPixelFormat->dwFlags = DDPF_FOURCC;
     ret &= gst_structure_get_fourcc (structure, "format", &fourcc);
@@ -1894,7 +1894,7 @@ gst_directdraw_sink_bufferpool_clear (GstDirectDrawSink * ddrawsink)
     ddrawsink->buffer_pool = g_slist_delete_link (ddrawsink->buffer_pool,
         ddrawsink->buffer_pool);
     gst_directdraw_sink_surface_destroy (ddrawsink, surface);
-    gst_buffer_unref (surface);
+    gst_buffer_unref (GST_BUFFER(surface));
   }
   g_mutex_unlock (ddrawsink->pool_lock);
 }
Comment 1 Sebastian Dröge (slomo) 2009-02-27 19:41:49 UTC
commit 27d1ef8a865449346a8c88faa0273983f64cff8d
Author: LRN <lrn1986@gmail.com>
Date:   Fri Feb 27 20:40:31 2009 +0100

    directdrawsink: Fix type mismatches
    
    Fixes bug #573343.