After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573165 - Generate additional export files for gstreamer app plugin
Generate additional export files for gstreamer app plugin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Windows
: Normal enhancement
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-25 18:20 UTC by LRN
Modified: 2009-02-25 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description LRN 2009-02-25 18:20:39 UTC
Add $(GST_LIB_LDFLAGS) to libgstapp_@GST_MAJORMINOR@_la_LDFLAGS in gst-plugins-base/gst-libs/gst/app/Makefile.am
This causes --export-symbols-regex argument to appear at link time and leads to .def and .exp file being generated alongside with .dll
app plugin seems to be the only plugin that is not generating .def file. Which is odd, because gstapp is the only plugin that actually exports useful API function on its own.
Comment 1 Tim-Philipp Müller 2009-02-25 19:54:57 UTC
Nice catch, thanks!

commit 07d2dbfdfec75e9cded0ac90e3bb0a33929de4a1
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Feb 25 19:40:43 2009 +0000

    app: add win32 .def file and only export functions we want exported
    Add a .def file for win32 builds (and make check-exports).
    Fix LDFLAGS in Makefile.am, so the usual export regexps are used (fixes #573165).
    Make sure private marshaller functions aren't exported by prefixing them with __gst;
    also rename gst_app_marshal_OBJECT__VOID to _BUFFER__VOID, make it static and add
    a comment why we're not using glib-genmarshal for this one.