After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573050 - Banshee has unnecessarily hard requirement on DBus?
Banshee has unnecessarily hard requirement on DBus?
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.4.2
Other All
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 595021 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-02-25 00:48 UTC by Michel Alexandre Salim
Modified: 2009-09-13 00:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes an exception on Banshee startup when DBus is disabled. (1.26 KB, patch)
2009-02-25 10:08 UTC, Alexander Kojevnikov
committed Details | Review

Description Michel Alexandre Salim 2009-02-25 00:48:43 UTC
Please describe the problem:
Banshee currently does not run at all if DBus is not running. It would be nice if the DBus-related parts could just simply be disabled if the DBus daemon is not running.

Steps to reproduce:
$ unset DBUS_SESSION_BUS_ADDRESS
$ banshee-1

Actual results:
Unhandled Exception: System.Exception: Unable to open the session message bus.
---> System.ArgumentNullException: Argument cannot be null.
Parameter name: address
  at NDesk.DBus.Bus.Open (System.String address) [0x00000] 
  at NDesk.DBus.Bus.get_Session () [0x00000] 
  --- End of inner exception stack trace ---
  at NDesk.DBus.Bus.get_Session () [0x00000] 
  at Banshee.ServiceStack.DBusConnection.get_ApplicationInstanceAlreadyRunning
() [0x00000] 
  at Booter.Booter.Main () [0x00000] 


Expected results:
This should not cause a crash (chalk one argument in favour of checked exceptions). At the minimum, the dbus-not-running exception should be caught; after that, either Banshee runs without DBus-requiring services, or it should exit cleanly.

Does this happen every time?
Yes

Other information:
See downstream Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=487152
Comment 1 Alexander Kojevnikov 2009-02-25 10:08:10 UTC
Created attachment 129478 [details] [review]
Fixes an exception on Banshee startup when DBus is disabled.
Comment 2 Bertrand Lorentz 2009-06-06 10:32:23 UTC
Thanks Alex, please commit.
Comment 3 Alexander Kojevnikov 2009-06-06 10:37:54 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Alexander Kojevnikov 2009-09-13 00:51:02 UTC
*** Bug 595021 has been marked as a duplicate of this bug. ***