After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573023 - Migrate deprecated gnome-vfs to gio/gvfs
Migrate deprecated gnome-vfs to gio/gvfs
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: colorblind-applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Willie Walker
Willie Walker
Depends on:
Blocks: 588322
 
 
Reported: 2009-02-24 20:16 UTC by André Klapper
Modified: 2009-07-11 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.14 KB, patch)
2009-03-01 16:01 UTC, André Klapper
none Details | Review
Replaces gnomevfs.url_show by gtk.show_uri (1.58 KB, patch)
2009-03-22 11:22 UTC, Simon van der Linden
committed Details | Review

Description André Klapper 2009-02-24 20:16:30 UTC
http://live.gnome.org/GioPort

> $:andre\> grep -r vfs .
> ./colorblind/ui/About.py:import gtk, gtk.gdk, gnomevfs, gobject
> ./colorblind/ui/About.py:gnomevfs.url_show("mailto:%s" % mail)
> ./colorblind/ui/About.py:gnomevfs.url_show(link)

> ./colorblind/Utils.py:import gtk, gtk.gdk, gnome.ui, gobject, gnomevfs
> ./colorblind/ColorblindApplet.py:import gnomeapplet, gtk, gtk.gdk, gconf, gnomevfs, gobject, bonobo, ORBit
Comment 1 André Klapper 2009-03-01 16:01:06 UTC
Created attachment 129785 [details] [review]
patch

i can't get gnome-mag to *fail* when compiling, even by setting complete bogus module import names and using -Wl --as-needed. Frustrating.
Hence this patch is *completely* untested and probably wrong.

We should probably get rid of gnome-mag - the code looks... ancient.
Comment 2 André Klapper 2009-03-01 19:20:36 UTC
...or gtk.show_uri ? shrug
Comment 3 Frederic Peters 2009-03-22 11:14:33 UTC
It wouldn't be gnome-mag but the colorblind applet, but it won't add to my panel, even after I fixed an obvious bug:

ColorblindApplet.py has:
  from colorblind.ui.ColorblindPreferencesUI import show_preferences

but ui/ColorblindPreferencesUI.py has:
  import colorblind, colorblind.Utils, colorblind.ColorblindApplet

which means the import of that file will stop before show_preferences is defined, which in turn means the import in ColorblindAppley.py fails with ImportError.

Comment 4 Simon van der Linden 2009-03-22 11:22:08 UTC
Created attachment 131118 [details] [review]
Replaces gnomevfs.url_show by gtk.show_uri
Comment 5 Nagappan Alagappan 2009-03-23 12:20:26 UTC
Patches are good to commit

Thanks
Comment 6 Nagappan Alagappan 2009-03-23 12:23:45 UTC
Reassigning bug to Willi, as Bill no longer work for Sun. Willi, request to assign the bug to concern developer.

Thanks
Comment 7 Willie Walker 2009-03-30 16:22:16 UTC
(In reply to comment #6)
> Reassigning bug to Willi, as Bill no longer work for Sun. Willi, request to
> assign the bug to concern developer.
> 
> Thanks

This definitely needs some love. I spent all day yesterday and all morning today trying to figure out how to get gnome-mag to build.  I'm missing something, and I'm hoping maybe Carlos can help.
Comment 8 André Klapper 2009-03-30 16:58:30 UTC
(In reply to comment #7)
> I spent all day yesterday and all morning today trying to figure out 
> how to get gnome-mag to build.

What issues are you exactly running into?
Comment 9 Willie Walker 2009-03-30 17:04:16 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > I spent all day yesterday and all morning today trying to figure out 
> > how to get gnome-mag to build.
> 
> What issues are you exactly running into?

Heh - I was just going to explain that.  I can get it to build just fine without libcolorblind, but as soon as I start enabling libcolorblind (which is what I believe this bug is related to), I run into a whole bunch of Python issues.  I believe it may be because I'm working with Python 2.4 and it might be that the gnome-mag stuff requires Python 2.6 (but I'm not sure).
Comment 10 André Klapper 2009-03-30 17:19:15 UTC
So it seems we talk about the flag '--enable-colorblind-applet=yes' here.
Comment 11 Willie Walker 2009-03-30 17:26:30 UTC
(In reply to comment #10)
> So it seems we talk about the flag '--enable-colorblind-applet=yes' here.

Yep - it's automatically enabled if you have built/installed libcolorblind from http://alioth.debian.org/frs/download.php/1952/colorblind-0.0.1.tar.gz.

Since the patch in question deals in the colorblind subdirectory of gnome-mag, I assumed I needed libcolorblind installed in order to be able to build/test the patch attached to this bug.  The unfortunate thing is that my machine doesn't seem to be up to the Python version needed to make it work.  :-(  I also cannot upgrade my Python to 2.6 right now.  :-(  So, I'm kind of useless when it comes to this patch.
Comment 12 André Klapper 2009-03-30 17:41:40 UTC
Python 2.5.2 works fine here, but as I said: I can also remove the gnomevfs import and jhbuild still does not fail. That sucks for testing.
Comment 13 Willie Walker 2009-03-30 17:47:41 UTC
(In reply to comment #12)
> Python 2.5.2 works fine here, but as I said: I can also remove the gnomevfs
> import and jhbuild still does not fail. That sucks for testing.

Yeah.  I'm stuck at Python 2.4 right now.  :-(  Let's see if Carlos has some cycles to take a quick look at this.  Carlos, if you can review the patch and approve it, I'll be happy to do the rest (i.e., commit it, spin up a new release, etc.)
Comment 14 Carlos Eduardo Rodrigues Diógenes 2009-03-30 18:50:54 UTC
For me the patch looks OK and due the comments I guess that it's also works.

I don't know how to solve the concerns presented by Klapper about gnome-mag and jhbuild. If someone can point me to a python code that fails due missing of imports I will be happy to make a patch for gnome-mag fail while running under jhbuild.
Comment 15 André Klapper 2009-04-03 12:37:57 UTC
(In reply to comment #14)
> I don't know how to solve the concerns presented by Klapper about gnome-mag and
> jhbuild. If someone can point me to a python code that fails due missing of
> imports I will be happy to make a patch for gnome-mag fail while running under
> jhbuild.

For me it doesn't fail. In fact I'd LOVE to get it to fail for testing. :-P
It fails for Willie.

Soooo.... Anybody willing to commit this (and maybe branch for gnome-2-26 before, to be on the safe side) so it can get some more testing?
Comment 16 Willie Walker 2009-04-03 16:37:41 UTC
(In reply to comment #15)
> For me it doesn't fail. In fact I'd LOVE to get it to fail for testing. :-P
> It fails for Willie.
> 
> Soooo.... Anybody willing to commit this (and maybe branch for gnome-2-26
> before, to be on the safe side) so it can get some more testing?

Well...it just fails for me because I'm at Python 2.4.  I have a spare machine laying around that I can try to configure for this, but if someone beats me to it first, I won't complain.
Comment 17 Willie Walker 2009-04-04 15:11:29 UTC
I built and tested this on GNOME 2.26.0 with colorblind-0.0.1 installed (I needed to open/fix bug #577937 in order to test the changes).  To test these changes, I ran the colorblind applet and made sure I did the appropriate actions in the applet's GUI to exercise the code paths (e.g., looking at About, clicking on e-mail addresses, clicking on web page URL's).  These all worked fine, so I committed the patch.

I'll try to spin up a new release for 2.26.1 sometime next week -- the machine I'm used for this ends up creating a configure file that refers to a version of the l10n tools that are not compatible with GNOME 2.24 systems.  The machine I will use to make the release will produce a configure file compatible with both 2.24 and 2.26 systems (I hope).  This is just anal-retentiveness just in case someone wants to build the release on 2.24.

I'm going to keep this bug open as a reminder that a new release with this fix still needs to be created.
Comment 18 Willie Walker 2009-04-12 00:26:26 UTC
Released in gnome-mag 0.15.6, which is good for GNOME 2.24.x and GNOME 2.26.x.