After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572913 - Migrate from deprecated esound to libcanberra
Migrate from deprecated esound to libcanberra
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: Gerd Kohlberger
David Bolter
: 571489 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-02-23 22:02 UTC by André Klapper
Modified: 2009-04-02 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
migrate to libcanberra (12.49 KB, patch)
2009-03-23 18:28 UTC, Gerd Kohlberger
none Details | Review
updated patch (13.86 KB, patch)
2009-03-29 12:53 UTC, Gerd Kohlberger
none Details | Review
new sound 1 (27.37 KB, application/octet-stream)
2009-03-29 12:55 UTC, Gerd Kohlberger
  Details
new sound 2 (172.35 KB, application/octet-stream)
2009-03-29 12:56 UTC, Gerd Kohlberger
  Details

Description André Klapper 2009-02-23 22:02:53 UTC
$:andre\> grep -r "include <esd" .
./gok/gok-sound.c:#include <esd.h>

$:andre\> grep -r "esd_" .
./gok/gok-sound.c:    esd_sample_free (gnome_sound_connection, *((gint *)sample_id) );
./gok/gok-sound.c:    esd_sample_play (gnome_sound_connection, *sample_id);

$:andre\> grep -r "esound" .
./configure.in:	esound			\
./gok-1.0.pc.in:Requires: libgnomeui-2.0 cspi-1.0 libspi-1.0 libbonobo-2.0 atk gtk+-2.0 gail libwnck-1.0 esound
Comment 1 André Klapper 2009-03-04 16:40:36 UTC
Can somebody work on this soon, please?
This is the very last module in GNOME that directly depends on esound and we want to get rid of this dependency, finally.
Comment 2 David Bolter 2009-03-23 16:34:24 UTC
Gerd, do you have cycles for this one?
Comment 3 André Klapper 2009-03-23 16:41:58 UTC
See bug 557921 and bug 558285 for similar issues of other applications.
See http://0pointer.de/lennart/projects/libcanberra/ for the spec.

Maybe Lennart himself is kind enough to provide a patch if he finds some time...
Comment 4 Gerd Kohlberger 2009-03-23 17:41:57 UTC
David: until the end of April I have very little time during the week. I've started to work on a patch some time ago but got sidetracked by #574713. I'll post what I have so far - maybe someone will pick it up. :) If not I'll probably have time to finish it this weekend.
Comment 5 Gerd Kohlberger 2009-03-23 18:28:50 UTC
Created attachment 131211 [details] [review]
migrate to libcanberra

The patch should be finished, except that it doesn't work. I think the problem is that all sound files must be installed in the sound-themes directory. (currently they are in DATADIR/gok)
Comment 6 Gerd Kohlberger 2009-03-26 16:11:40 UTC
*** Bug 571489 has been marked as a duplicate of this bug. ***
Comment 7 Gerd Kohlberger 2009-03-29 12:53:34 UTC
Created attachment 131617 [details] [review]
updated patch

- install sounds into freedesktop sound theme

- remove test-gok-sound. Playback during distcheck doesn't work because our sounds aren't installed in a theme dir.

- 2 new sounds. The old sounds are mono/6kHz and are below the minimum requirements of the spec. I've tried to resample the old files but the resulting quality was very bad.
Comment 8 Gerd Kohlberger 2009-03-29 12:55:39 UTC
Created attachment 131618 [details]
new sound 1
Comment 9 Gerd Kohlberger 2009-03-29 12:56:58 UTC
Created attachment 131619 [details]
new sound 2
Comment 10 André Klapper 2009-03-31 12:25:26 UTC
Thanks a lot. Can we get this in soon for the 2.27.x branch so it receives some testing?
Comment 11 Gerd Kohlberger 2009-04-02 17:35:25 UTC
Committed to trunk.