Bug 572807 – Accessibility keybindings not properly set

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 572807 - Accessibility keybindings not properly set


Summary:	Accessibility keybindings not properly set


Status:	RESOLVED FIXED

Product:	gnome-settings-daemon
Classification:	Core
Component:	plugins
Version:	2.25.x
Hardware:	Other All

Importance:	Normal minor
Target Milestone:	---
Assigned To:	gnome-settings-daemon-maint
QA Contact:	gnome-settings-daemon-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-02-23 03:12 UTC by Hernando Torque
Modified:	2009-02-23 23:06 UTC

See Also:
GNOME target:	---
GNOME version:	2.25/2.26

Attachments
add name keys to schema (2.39 KB, patch) 2009-02-23 18:03 UTC, Jens Granseuer	none	Details \| Review

Description Hernando Torque 2009-02-23 03:12:30 UTC

Please describe the problem:
Custom keybindings consist of an action, a binding, and a name. Gnome-settings-daemon doesn't set the name key in gconf for the three accessibility keybindings it adds in data/gnome-settings-daemon.schemas.in (magnifier, screenreader, onscreenkeyboard), which causes gnome-keybinding-properties to show just "binding" as the keybinding's action.

Steps to reproduce:
1. Open gnome-keybinding-properties, "Custom Shortcuts" section.

Actual results:


Expected results:
Entries with proper naming. :-)

Does this happen every time?


Other information:

Comment 1 Jens Granseuer 2009-02-23 18:03:47 UTC

Created attachment 129354 [details] [review]
add name keys to schema

This patch fixes the problem, but constitutes a freeze break.

Freeze break has been requested.

Comment 2 Wouter Bolsterlee (uws) 2009-02-23 18:35:13 UTC

The strings inside the <short> and <long> elements do not make much sense. In fact, they don't contain any useful information at all. Why is that in this patch?

Comment 3 Jens Granseuer 2009-02-23 18:55:32 UTC

Better phrasing welcome.

Comment 4 Wouter Bolsterlee (uws) 2009-02-23 19:09:01 UTC

See below.

+    <schema>
+      <key>/schemas/desktop/gnome/keybindings/magnifier/name</key>
+      <applyto>/desktop/gnome/keybindings/magnifier/name</applyto>
+      <owner>gnome-settings-daemon</owner>
+      <type>string</type>
+      <locale name="C">
+        <default>Toggle magnifier</default>
+        <short>Magnifier shortcut description</short>

Suggestion: "The name of the keyboard shortcut to toggle the magnifier."

+        <long>
+          Description for the magnifier shortcut.
+        </long>

Suggestion: "This is the name of the keyboard shortcut to toggle the magnifier. This name will be shown in the keyboard shortcut preferences dialog."

+      </locale>
+    </schema>

Idem for the other keys.

Comment 5 Jens Granseuer 2009-02-23 19:22:55 UTC

Thanks for the prompt replies. Committed without the fullstop in the short description (both for consistency and sensibility ;-)).

2009-02-23  Jens Granseuer  <...>

        * data/gnome-settings-daemon.schemas.in: add missing keys for a11y
        shortcut names (bug #572807)

Comment 6 Wouter Bolsterlee (uws) 2009-02-23 19:37:16 UTC

Great! Thanks for committing this right away.

Comment 7 Hernando Torque 2009-02-23 23:06:55 UTC

Yup, thanks! Three minor bugs reported and all fixed within 24 hours. *stunning*