After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572521 - gvfsd-cdda create two different Audio Disc Icons on Desktop
gvfsd-cdda create two different Audio Disc Icons on Desktop
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: cdda backend
1.1.x
Other opensolaris
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2009-02-20 06:55 UTC by jerry tan
Modified: 2009-03-11 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't show shadowed mounts in computer:/// (512 bytes, patch)
2009-03-11 09:31 UTC, Alexander Larsson
none Details | Review

Description jerry tan 2009-02-20 06:55:42 UTC
with gnome-2.25.5, gvfs1.1.6, 
One AudioCD inserted, two different Audio Disc icons are created on Desktop.

And if I kill gvfsd-cdda, these 2 icons will disappear.
Comment 1 Alexander Larsson 2009-03-05 12:18:30 UTC
Any cd, or is it some specific one? (For instance, one with a data partition)
Comment 2 Bastien Nocera 2009-03-05 14:10:29 UTC
Still the same crappy downstream patch? See dupe for details, and STOP FILING DUPES.

Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 563090 ***
Comment 3 jerry tan 2009-03-06 03:14:16 UTC
not the dup of 563090.

because this time, I build gvfsd-cdda with libcdio library, 

only one gvfsd-cdda process creates two AudioCD icon on desktop.

I reproduce it with gvfs-1.1.7





Comment 4 jerry tan 2009-03-06 06:17:06 UTC
cdio I used is libcdio8.0
gvfs 1.1.7, 
hal 0.5.8
Comment 5 jerry tan 2009-03-06 07:29:10 UTC
Two different icons on desktop
it seems that one is bringing up by gvfsd-cdda
another is created by gvfs-hal-volume-monitor.



When I run gvfs-hal-volume-monitor manually on terminal, 
it will popup a warning dialog" location is already mounted", that's right.
but it will create another audio icon on desktop.
everytime I run it again, it will create one audio icon.



Another thing:

  my audio cd is mounted as /dev/dsk/c0t1d0p0, 
but if I run gvfs-mount cdda://c0t1dp1, 
gvfs-mount cdda://c0t1dp2
two audio cd icon show on desktop.


They are not dup of 563090, because I build libcdio on my system, 
and link gvfsd-cdda with it.
Comment 6 David Zeuthen (not reading bugmail) 2009-03-06 18:59:43 UTC
It would be helpful if you 

 1. include the output of 'gvfs-mount -li'

 2. include the output of 'mount'

 3. tell us what patches you are applying to gvfs and gio
    (preferably just links to them)

Thanks.

Comment 7 Alexander Larsson 2009-03-11 09:17:50 UTC
I guess the gvfsd-cdda icon is the mount, while the gvfs-hal-volume-monitor one is the volume. Shouldn't the volume shadowing hide the volume one though?
Comment 8 Alexander Larsson 2009-03-11 09:21:40 UTC
I get two icons too. This is the gvfs-mount output:

$ gvfs-mount -li
Drive(0): CD-RW/DVD±RW Drive
  Type: GProxyDrive (GProxyVolumeMonitorHal)
  ids:
   hal-udi: '/org/freedesktop/Hal/devices/storage_model_CD_DVDW_SH_S182M'
   unix-device: '/dev/sr0'
  themed icons:  [drive-optical-recorder]  [drive-optical]  [drive]
  is_media_removable=1
  has_media=1
  is_media_check_automatic=1
  can_poll_for_media=1
  can_eject=1
  Volume(0): Audio Disc
    Type: GProxyVolume (GProxyVolumeMonitorHal)
    ids:
     hal-udi: '/org/freedesktop/Hal/devices/volume_part_1_size_29255680'
     unix-device: '/dev/sr0'
    activation_root=cdda://sr0/
    themed icons:  [drive-optical-recorder]  [drive-optical]  [drive]
    can_mount=1
    can_eject=1
    Mount(0): Audio Disc -> cdda://sr0/
      Type: GProxyShadowMount (GProxyVolumeMonitorHal)
      themed icons:  [drive-optical-recorder]  [drive-optical]  [drive]
      x_content_types: x-content/audio-cdda
      can_unmount=1
      can_eject=1
      is_shadowed=0
Mount(0): Audio Disc -> cdda://sr0/
  Type: GDaemonMount
  themed icons:  [media-optical-audio]  [media-optical]  [media]
  x_content_types: x-content/audio-cdda
  can_unmount=1
  can_eject=0
  is_shadowed=1


It seems the GDaemonMount is shadowed, but still displayed...
Comment 9 Alexander Larsson 2009-03-11 09:30:46 UTC
When I say "displayed" I mean its visible in computer:///. All other places in nautilus are OK. Ah, except the panel. We should fix that too.
Comment 10 Alexander Larsson 2009-03-11 09:31:37 UTC
Created attachment 130448 [details] [review]
Don't show shadowed mounts in computer:///
Comment 11 David Zeuthen (not reading bugmail) 2009-03-11 13:19:44 UTC
(In reply to comment #10)
> Created an attachment (id=130448) [edit]
> Don't show shadowed mounts in computer:///
> 

Good catch, thanks Alex. Seems like I forgot to patch GVfs for the shadowing stuff.
Comment 12 Alexander Larsson 2009-03-11 14:04:08 UTC
2009-03-11  Alexander Larsson  <alexl@redhat.com>

	Bug 572521 – gvfsd-cdda create two different Audio Disc Icons on Desktop

	* daemon/gvfsbackendcomputer.c (recompute_files):
	Don't show shadowed mounts.