After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572358 - law encoders _getcaps ignore rate/channel if not both are set
law encoders _getcaps ignore rate/channel if not both are set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-19 01:49 UTC by Olivier Crête
Modified: 2009-02-22 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
separate rate/channel negotiation (3.65 KB, patch)
2009-02-19 01:50 UTC, Olivier Crête 		committed Details | Review
implement getcaps in decoders (5.38 KB, patch)
2009-02-19 02:02 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2009-02-19 01:49:50 UTC 
Test:

gst-launch-0.10 audiotestsrc ! alawenc ! audio/x-alaw, rate=10000 ! fakesink

The _getcaps() func in the alaw/mulaw encoders ignore the rate or channel ocunt if both are not set, attaching git patch.
Comment 1 Olivier Crête 2009-02-19 01:50:43 UTC 
Created attachment 129026 [details] [review]
separate rate/channel negotiation
Comment 2 Olivier Crête 2009-02-19 02:02:05 UTC 
Created attachment 129027 [details] [review]
implement getcaps in decoders

while I'm giving the law elements some love, here are are patches to implement getcaps in the decoders too
Comment 3 Sebastian Dröge (slomo) 2009-02-22 17:48:45 UTC 
commit bfcf84a3eb766f2da0cf1cfdecdd9dcdf847f75f
Author: Olivier Crete <tester@tester.ca>
Date:   Sun Feb 22 18:47:35 2009 +0100

    alaw/mulaw: Implement _getcaps function for alaw/mulaw decoders
    
    Fixes bug #572358.

commit b3a90202c12619bb32712a5d185d48b6286911e6
Author: Olivier Crete <tester@tester.ca>
Date:   Sun Feb 22 18:46:03 2009 +0100

    alaw/mulaw: Don't require both, rate and channel, to be set in _getcaps
    
    Fixes bug #572358.