After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572328 - do not pre-emptively generate thumbnails and waveforms when dragging
do not pre-emptively generate thumbnails and waveforms when dragging
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.13.1
Assigned To: Brandon Lewis
Pitivi maintainers
Depends on: 570117
Blocks: 572327
 
 
Reported: 2009-02-18 21:46 UTC by Jean-François Fortin Tam
Modified: 2009-05-14 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-02-18 21:46:02 UTC
When dragging a clip from the library to the timeline, it seems that waveforms and thumbnails start generating while I'm still in the drag operation (ie: have not released the mouse button).

This is undesirable because it makes dragging jerky, and will likely cause problems when dragging multiple clips at once.
Comment 1 Jean-François Fortin Tam 2009-02-18 21:47:37 UTC
Not sure if it blocks or depends on bug #570117, but I figured out that they'd be related.
Comment 2 Brandon Lewis 2009-02-19 00:01:44 UTC
well, once all the thumbnails have been fetched, dragging is fairly smooth. The issue is that the fetching/rendering stuff periodically blocks the UI. I thought that I set it up so that the thumbnails would be rendered in the pipeline context, but either this isn't what's actually happening, or doing intensive processing intensive processing in another thread can still affect the latency of the UI thread.

I'll try to set it up so that the UI can request that the previewer not fetch new thumbnails on updates. But multiple timeline objects can share the same previewing pipeline, so that might not be good enough. 
Comment 3 Brandon Lewis 2009-03-01 04:39:37 UTC
Some of the recent patches have sped up thumbnail generation quite a bit. The initial drag into the timeline seems much less choppy. Try it, and if you think It's usable, I can just close this bug.
Comment 4 Jean-François Fortin Tam 2009-03-02 14:28:18 UTC
Yeah, it seems to be fixed by the performance improvements now. Many thanks!