After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572258 - profiler hooks should be installed only when needed
profiler hooks should be installed only when needed
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2009-02-18 11:06 UTC by Tommi Komulainen
Modified: 2009-02-23 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
install profiler hooks only if profiling is desired (2.90 KB, patch)
2009-02-18 11:09 UTC, Tommi Komulainen
committed Details | Review

Description Tommi Komulainen 2009-02-18 11:06:32 UTC
The profiler, when created, automatically installs its hooks regardless of whether outputting the profile data is enabled or not. As collecting the profiling data can slow down execution the hooks should be installed only when needed.
Comment 1 Tommi Komulainen 2009-02-18 11:09:04 UTC
Created attachment 128967 [details] [review]
install profiler hooks only if profiling is desired

Collecting statistics can be somewhat expensive so avoid any slowdowns
if no one is interested in results anyway.
Comment 2 Johan Bilien 2009-02-18 12:33:12 UTC
Looks good
Comment 3 Tommi Komulainen 2009-02-23 10:05:32 UTC
Fixed in c8c9067124b4b5e6ba063d439ffdd44ba5e62f67