GNOME Bugzilla – Bug 572099
[Viewer] Doesn't take project settings into account
Last modified: 2009-05-12 16:52:59 UTC
This is a blocker for http://www.pitivi.org/wiki/2009:_A_Workspace_Odyssey My camcorder produces 1280x720 H.264+AAC files at 29.97 fps. Those files were perfectly handled by pitivi 0.11.3, but are not handled correctly anymore by PiTiVi git. They are recognized as 960x720 http://jeff.ecchi.ca/public/test%20HD%205.MOV http://jeff.ecchi.ca/public/test%20HD%201.MOV This is not specific to my own camcorder, as files produced by another similar camcorder are also affected: http://jeff.ecchi.ca/public/CLIP0041.AVI
The "display size" code in the UI was borked. commit 89aeb198bfb6cb1fe298bf9163464c75101e6bee Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Feb 17 08:12:46 2009 +0100 UI: Fix beautification of VideoStream 'display' width/height. Fixes #572099
*** Bug 569895 has been marked as a duplicate of this bug. ***
This is fixed in the clip library view (the text says 1280x960), but the playback preview thingy still displays the thing letterboxed instead of using the real resolution. I tried setting manually the resolution and framerate in the projects settings, no luck.
Additional test case, produced by the same camcorder, but behaves differently in SD than the HD samples http://jeff.ecchi.ca/public/test%20SD%203.MOV Recently, you fixed the resolution "in the clip library but not in the previewer" for the 1280x720 clips, *but*, for this 720x480 clip, it doesn't show up correctly in the clip library *either* (whereas the 1280x720 clips do).
The issue is in fact in the viewer code. We don't adjust the aspect ratio of the Frame to the aspect ratio of the project. Somethign simpler we could do is ... No longer use an AspectFrame but just a regular one that expands to as much room as possible.
I'd indeed prefer the aspect ratio to be clamped to the project and render settings. The reason is that if a clip is going to look squashed or letterboxed, I would like the previewer to actually reflect that (and be able to crop/zoom/whatever to fix it and see the results, but that's another issue). The previewer should tell me whenever something is wrong with resolutions or aspect ratios. As such, the previewer's aspect ratio (and maybe native resolution, if such a concept exists) should be based on: - the project resolution (when doing the editing) - the render resolution (when doing the live preview of the render progress)
I saw that in viewer, py, self.aframe = gtk.AspectFrame(xalign=0.5, yalign=0.5, ratio=4.0/3.0, If I change it to self.aframe = gtk.AspectFrame(xalign=0.5, yalign=0.5, ratio=16.0/9.0, It solves the problem for my use case. Now, the question is, why not simply use the project resolution settings and calculate those values (and, when rendering, calculate those values based on the render resolution)?
*** Bug 575968 has been marked as a duplicate of this bug. ***
commit 019cc43d0989cf549251c3aeac7259f750feb6c7 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue May 12 18:50:32 2009 +0200 UI: Adjust Viewer DAR whenever the project settings change. Fixes #572099 commit 2774c16bd0f4b1c0ff415d6ef8be88b8c098d054 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue May 12 18:39:13 2009 +0200 ui: Set project DAR on Viewer when switching to the timeline.