After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571877 - Get rid of deprecated Bonobo
Get rid of deprecated Bonobo
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.29.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 614230 (view as bug list)
Depends on: 572131
Blocks: 588321 620830
 
 
Reported: 2009-02-15 20:10 UTC by André Klapper
Modified: 2011-01-21 20:19 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
0001-port-to-libpanel-applet-3.0.patch (21.92 KB, patch)
2010-08-23 05:04 UTC, Saleem Abdulrasool
none Details | Review
0001-port-to-libpanel-applet-3.0.patch (21.92 KB, patch)
2010-10-18 01:05 UTC, Saleem Abdulrasool
none Details | Review
0001-port-to-libpanel-applet-3.0.patch (21.96 KB, patch)
2010-10-18 04:06 UTC, Saleem Abdulrasool
none Details | Review

Description André Klapper 2009-02-15 20:10:49 UTC
libbonobo and libbonoboui are deprecated as per
http://live.gnome.org/TwoPointTwentyfive/Platform and hence the dependency
should be completely removed.

See for example http://www.ibm.com/developerworks/linux/library/l-dbus.html or
http://www.mail-archive.com/gnome-devel-list@gnome.org/msg00997.html .


./gdm/gui/user-switch-applet/applet.c:#include <bonobo/bonobo-main.h>
./gdm/gui/user-switch-applet/applet.c:#include <bonobo/bonobo-ui-util.h>
Comment 1 Olof Kindgren 2009-12-16 13:10:41 UTC
If I understand correctly, the bonobo dependancy is because fusa is a gnome applet. Would it be feasible to reimplement it as a notification icon (gtkstatusicon) instead? Or is there any other workaround?
Comment 2 André Klapper 2010-04-12 19:46:11 UTC
http://live.gnome.org/GnomeGoals/AppletsDbusMigration if that helps anybody.
Comment 3 Ray Strode [halfline] 2010-06-09 18:58:23 UTC
*** Bug 614230 has been marked as a duplicate of this bug. ***
Comment 4 Saleem Abdulrasool 2010-08-22 23:04:23 UTC
Working on a patch for this.

It seems that there is a fair amount of "dead" code in the applet currently.  There is disabled code for presence information as well as code for integrated user administration.  However, I dont see any way to actually enable that currently (its simply #ifdef'ed out).

I just want to verify that this is really the case as Im basing my patch on top of the removal of this dead code.
Comment 5 Saleem Abdulrasool 2010-08-23 05:04:20 UTC
Created attachment 168540 [details] [review]
0001-port-to-libpanel-applet-3.0.patch

Note that this patch is entirely untested at this point, simply know that make ; make check works and that it doesnt use the libpanel-2.0 interfaces.
Comment 6 Hussam Al-Tayeb 2010-09-17 11:00:42 UTC
I tried the patch against gdm 2.31.92
gdm-user-switch-applet builds and the package installs correctly.
but I don't seen it when in add applets dialog in gnome-panel.
Comment 7 Hussam Al-Tayeb 2010-09-17 11:04:53 UTC
Is it supposed to install something in /usr/share/gnome-panel/applets/?
Comment 8 Saleem Abdulrasool 2010-09-17 23:24:15 UTC
Yes, it is supposed to install a panel-applet file there.  Ill have a look over the weekend.
Comment 9 Hussam Al-Tayeb 2010-10-16 02:10:51 UTC
(In reply to comment #8)
> Yes, it is supposed to install a panel-applet file there.  Ill have a look over
> the weekend.

Hello, did you have time to look over it?
Comment 10 Saleem Abdulrasool 2010-10-18 01:05:14 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > Yes, it is supposed to install a panel-applet file there.  Ill have a look over
> > the weekend.
> 
> Hello, did you have time to look over it?

Yeah, I looked over it.  Found the issue with the missing file (stupid typo).  Attaching the new version of the patch.  Still not sure how to test this though :-(.
Comment 11 Saleem Abdulrasool 2010-10-18 01:05:45 UTC
Created attachment 172575 [details] [review]
0001-port-to-libpanel-applet-3.0.patch
Comment 12 Hussam Al-Tayeb 2010-10-18 01:48:50 UTC
I tried it. compiles fine.

/usr/share/gnome-panel/applets/org.gnome.gdm.UserSwitch.panel-applet
says Location=@LOCATION@
instead of something like Location=/usr/lib/gdm/gdm-user-switch-applet 

(libexecdir/gdm-user-switch-applet)
Comment 13 Hussam Al-Tayeb 2010-10-18 01:52:18 UTC
also in /usr/share/dbus-1/services/org.gnome.panel.applet.GdmUserSwitchAppletFactory.service

Exec= line is empty
it should say something like Exec=/usr/lib/gdm/gdm-user-switch-applet
Comment 14 Hussam Al-Tayeb 2010-10-18 01:54:07 UTC
after those two changes, I can successfully right click on gnome-panel, select add to panel and start the user switcher applet :)
Comment 15 Hussam Al-Tayeb 2010-10-18 01:55:08 UTC
in my case libexecdir is set to /usr/lib/gdm. in your distribution, it could be /usr/libexec/gdm.
Comment 16 Hussam Al-Tayeb 2010-10-18 03:42:33 UTC
Functionality also works. I was able to switch users. So all that's needed is the LOCATION and Exec line fixed and it should be ready to be committed.
Comment 17 Saleem Abdulrasool 2010-10-18 04:06:18 UTC
Created attachment 172579 [details] [review]
0001-port-to-libpanel-applet-3.0.patch

Third times a charm?  Should fix the build issues that you mentioned.
Comment 18 Hussam Al-Tayeb 2010-10-18 04:46:14 UTC
Yes, works now :)
Comment 19 Ray Strode [halfline] 2010-10-19 21:02:56 UTC
we're probably going to drop the user switch applet pretty soon (it's going to get reimplemented in the panel)
Comment 20 Matthias Clasen 2011-01-21 20:19:18 UTC
Looks like there's no more bonobo in master