GNOME Bugzilla – Bug 571877
Get rid of deprecated Bonobo
Last modified: 2011-01-21 20:19:18 UTC
libbonobo and libbonoboui are deprecated as per http://live.gnome.org/TwoPointTwentyfive/Platform and hence the dependency should be completely removed. See for example http://www.ibm.com/developerworks/linux/library/l-dbus.html or http://www.mail-archive.com/gnome-devel-list@gnome.org/msg00997.html . ./gdm/gui/user-switch-applet/applet.c:#include <bonobo/bonobo-main.h> ./gdm/gui/user-switch-applet/applet.c:#include <bonobo/bonobo-ui-util.h>
If I understand correctly, the bonobo dependancy is because fusa is a gnome applet. Would it be feasible to reimplement it as a notification icon (gtkstatusicon) instead? Or is there any other workaround?
http://live.gnome.org/GnomeGoals/AppletsDbusMigration if that helps anybody.
*** Bug 614230 has been marked as a duplicate of this bug. ***
Working on a patch for this. It seems that there is a fair amount of "dead" code in the applet currently. There is disabled code for presence information as well as code for integrated user administration. However, I dont see any way to actually enable that currently (its simply #ifdef'ed out). I just want to verify that this is really the case as Im basing my patch on top of the removal of this dead code.
Created attachment 168540 [details] [review] 0001-port-to-libpanel-applet-3.0.patch Note that this patch is entirely untested at this point, simply know that make ; make check works and that it doesnt use the libpanel-2.0 interfaces.
I tried the patch against gdm 2.31.92 gdm-user-switch-applet builds and the package installs correctly. but I don't seen it when in add applets dialog in gnome-panel.
Is it supposed to install something in /usr/share/gnome-panel/applets/?
Yes, it is supposed to install a panel-applet file there. Ill have a look over the weekend.
(In reply to comment #8) > Yes, it is supposed to install a panel-applet file there. Ill have a look over > the weekend. Hello, did you have time to look over it?
(In reply to comment #9) > (In reply to comment #8) > > Yes, it is supposed to install a panel-applet file there. Ill have a look over > > the weekend. > > Hello, did you have time to look over it? Yeah, I looked over it. Found the issue with the missing file (stupid typo). Attaching the new version of the patch. Still not sure how to test this though :-(.
Created attachment 172575 [details] [review] 0001-port-to-libpanel-applet-3.0.patch
I tried it. compiles fine. /usr/share/gnome-panel/applets/org.gnome.gdm.UserSwitch.panel-applet says Location=@LOCATION@ instead of something like Location=/usr/lib/gdm/gdm-user-switch-applet (libexecdir/gdm-user-switch-applet)
also in /usr/share/dbus-1/services/org.gnome.panel.applet.GdmUserSwitchAppletFactory.service Exec= line is empty it should say something like Exec=/usr/lib/gdm/gdm-user-switch-applet
after those two changes, I can successfully right click on gnome-panel, select add to panel and start the user switcher applet :)
in my case libexecdir is set to /usr/lib/gdm. in your distribution, it could be /usr/libexec/gdm.
Functionality also works. I was able to switch users. So all that's needed is the LOCATION and Exec line fixed and it should be ready to be committed.
Created attachment 172579 [details] [review] 0001-port-to-libpanel-applet-3.0.patch Third times a charm? Should fix the build issues that you mentioned.
Yes, works now :)
we're probably going to drop the user switch applet pretty soon (it's going to get reimplemented in the panel)
Looks like there's no more bonobo in master