After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571743 - Get rid of deprecated libgnomecanvas
Get rid of deprecated libgnomecanvas
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
evolution[cleanup]
Depends on:
Blocks:
 
 
Reported: 2009-02-14 15:39 UTC by André Klapper
Modified: 2009-04-09 03:18 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---


Attachments
delete depens from bonobo in makefile.(after patch you can delete components/html-editor) (666 bytes, patch)
2009-03-04 12:57 UTC, Denis Pauk
none Details | Review
delete depends from bonobo in testgtkhtml (13.72 KB, patch)
2009-03-09 18:54 UTC, Denis Pauk
committed Details | Review

Description André Klapper 2009-02-14 15:39:37 UTC
According to http://live.gnome.org/TwoPointTwentyfive/Platform libgnomecanvas has been deprecated for years and should be removed.


$:\> grep -r "#include <libgnomecanvas/" .
./gtkhtml/components/html-editor/gi-color-combo.c:#include <libgnomecanvas/gnome-canvas.h>
./gtkhtml/components/html-editor/gi-color-combo.c:#include <libgnomecanvas/gnome-canvas-pixbuf.h>
./gtkhtml/components/html-editor/gi-color-combo.c:#include <libgnomecanvas/gnome-canvas-rect-ellipse.h>
./gtkhtml/components/html-editor/gi-color-palette.c:#include <libgnomecanvas/gnome-canvas.h>
./gtkhtml/components/html-editor/gi-color-palette.c:#include <libgnomecanvas/gnome-canvas-rect-ellipse.h>
./gtkhtml/components/html-editor/gi-color-palette.h:#include <libgnomecanvas/gnome-canvas.h>

I'm also surprised that I can't find anything like "libgnomecanvas-2.0" in
configure.in...
Comment 1 Denis Pauk 2009-03-04 12:57:19 UTC
Created attachment 130014 [details] [review]
delete depens from bonobo in makefile.(after patch you can delete components/html-editor)

I found this files used to compile libgnome-gtkhtml-editor-*(.so/.la), but this files not installed when run make install. I think early use as bonobo component, it's right? May be need delete this component because bonobo deprecated?
Comment 2 André Klapper 2009-03-04 13:07:44 UTC
Uh, I just realize that all libgnomecanvas tools are in /gtkhtml/components/html-editor.

After I had filed this I discussed gtkhtml's bonobo dep...
<mbarnes> gtkhtml doesn't have a bonobo issue any more. that's what the 2.24 composer rewrite solved. the old html-editor composer based on bonobo is still in the tarball. but it's deprecated and not built by default anymore. we could dump html-editor today if we wanted. all "#include <bonobo" are in /components/html-editor/ except for the one in ./gtkhtml/gtkhtml/testgtkhtml.c

The plan is to remove it for 2.27.

If you're looking for a real challenge: Bug 571742. :-)
Comment 3 Denis Pauk 2009-03-09 18:54:30 UTC
Created attachment 130343 [details] [review]
delete depends from bonobo in testgtkhtml
Comment 4 Denis Pauk 2009-03-09 20:25:22 UTC
May be also need replace using libgnomeui to GtkUIManager(or some other implementation for menu)?
Comment 5 André Klapper 2009-03-10 00:15:02 UTC
As already said, gtkhtml/components/html-editor will DIE in a few weeks.
No work needed for this - it will be duplicated efforts.

Getting rid of libgnomeui is something needed for evolution and gtkhtml, yes (and a different issue). But evolution is currently more important, as gtkhtml might be replaced by webkit for 2.28 or 2.30.
Comment 6 Srinivasa Ragavan 2009-04-07 09:05:10 UTC
It seems fine to me. Matt, any thoughts?
Comment 7 André Klapper 2009-04-07 09:50:26 UTC
Branch and drop /gtkhtml/components/html-editor and then see what's still left. :-P
Comment 8 Matthew Barnes 2009-04-07 12:24:34 UTC
I see some minor issues in the test app that I'd want to clean up (if only to fix compiler warnings), but the configure.in / Makefile.am changes look good.

Approved for after we branch.
Comment 9 Matthew Barnes 2009-04-07 12:27:52 UTC
@Srini: Any chance we could branch GtkHtml early?

I doubt we'll be making many changes for 3.26.1.
Comment 10 Srinivasa Ragavan 2009-04-08 17:52:26 UTC
Branched & announced.
Comment 11 Matthew Barnes 2009-04-08 18:01:02 UTC
Great, thanks Srini.  I'll put html-editor out of its misery.
Comment 12 Matthew Barnes 2009-04-09 03:15:04 UTC
Committed Denis' patch and nuked html-editor.  Revision 9196.
Comment 13 Matthew Barnes 2009-04-09 03:18:00 UTC
No trace of libgnomecanvas left in GtkHtml.  I guess we're done here.