After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571516 - Compilation of BABL creates unwanted directories: use "convert" instead of "inkscape" to create pngs during build?
Compilation of BABL creates unwanted directories: use "convert" instead of "i...
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: babl
git master
Other All
: Normal normal
: 0.1.0
Assigned To: Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2009-02-12 18:23 UTC by Matteo 'Peach' Pescarin
Modified: 2009-03-27 20:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for using rsvg instead of inkscape (1.60 KB, patch)
2009-02-13 10:32 UTC, Matteo 'Peach' Pescarin
committed Details | Review

Description Matteo 'Peach' Pescarin 2009-02-12 18:23:01 UTC
Please describe the problem:
I found that after running "make" on babl svn, it tries to create a directory ~/.inkscape/ for no apparent reason.
Configure don't even talk about it.

Steps to reproduce:
1. sync the svn
2. ./autogen.sh
3. make


Actual results:
~/.inkscape/ is created

Expected results:
no junk in my home, or at least write it somewhere so I can disable it somehow

Does this happen every time?
yes

Other information:
I should mention that a while ago I had a similar problem with GEGL, which was solved adding an env var GEGL_SWAP before running make.
Comment 1 Martin Nordholts 2009-02-12 18:37:58 UTC
Hi and thanks for the bug report! I'm not able to reproduce, are you sure it is the babl make process that creates the folder? Please provide some evidence such as a strace, or run make in subfolders and see what folder-making that ends up creating .inkscape.
Comment 2 Matteo 'Peach' Pescarin 2009-02-12 19:11:05 UTC
I was writing an ebuild for my gentoo system, to install the svn version cause I'm using gimp from svn.
gentoo uses a sandbox for compilation and the error reported popped up when I tried to install it with the ebuild I wrote (nothing special in it) showing up as a "sandbox violation" right after "make" finished compiling the sources:

...
HTML: index.html. [OK]
 [OK]
make[2]: Leaving directory `/var/tmp/portage/media-libs/babl-9999/work/babl-9999/docs'
make[2]: Entering directory `/var/tmp/portage/media-libs/babl-9999/work/babl-9999'
make[2]: Leaving directory `/var/tmp/portage/media-libs/babl-9999/work/babl-9999'
make[1]: Leaving directory `/var/tmp/portage/media-libs/babl-9999/work/babl-9999'
>>> Source compiled.
--------------------------- ACCESS VIOLATION SUMMARY ---------------------------
LOG FILE = "/var/log/sandbox/sandbox-25437.log"

mkdir:     /root/.inkscape
open_wr:   /root/.inkscape/extension-errors.log
mkdir:     /root/.inkscape
open_wr:   /root/.inkscape/extension-errors.log
mkdir:     /root/.inkscape
open_wr:   /root/.inkscape/extension-errors.log
--------------------------------------------------------------------------------

if I remove sandboxing I can't find the dir, like it will be removed after creation... this thing is driving me crazy
if you confirm I'll post a strace of make
Comment 3 Martin Nordholts 2009-02-12 19:20:29 UTC
If I confirm what? I can confirm that this looks like a Gentoo issue ;) If the strace log sheds more light on this please attach the log to this report.
Comment 4 Kevin Cozens 2009-02-12 19:32:44 UTC
The Inkscape program is used when building PNG files from the SVG files in docs/graphics during a normal build of babl. It is the inkscape program which creates the ~/.inkscape directory.

I was about to close this as NOTABUG before comment #2 was added. This bug should be closed and a new one added to suggest the use of convert from ImageMagick to create the PNG files in the docs/graphics directory, or, the summary line should be changed to suggest a switch to the use of convert.
Comment 5 Martin Nordholts 2009-02-12 19:35:03 UTC
Another alternative approach is to suggest to Inkscape to allow Inkscape to be run without creating ~/.inkscape (maybe that's already possible)
Comment 6 Matteo 'Peach' Pescarin 2009-02-12 19:42:38 UTC
(In reply to comment #4)
> The Inkscape program is used when building PNG files from the SVG files in
> docs/graphics during a normal build of babl. It is the inkscape program which
> creates the ~/.inkscape directory.
> 
> I was about to close this as NOTABUG before comment #2 was added. This bug
> should be closed and a new one added to suggest the use of convert from
> ImageMagick to create the PNG files in the docs/graphics directory, or, the
> summary line should be changed to suggest a switch to the use of convert.
> 

thanks for your comment: I was thinking I was crazy :)
Comment 7 Kevin Cozens 2009-02-12 20:44:09 UTC
Confirming, and shortened summary slightly.
Comment 8 Matteo 'Peach' Pescarin 2009-02-13 10:32:08 UTC
Created attachment 128629 [details] [review]
patch for using rsvg instead of inkscape

as suggested by schumaml I've written a patch for using rsvg instead of inkscape or convert.
hope this works for you too.
Comment 9 Sven Neumann 2009-03-01 18:01:00 UTC
Looks good to me. Kevin, is there a problem with this approach or can we commit this?
Comment 10 Kevin Cozens 2009-03-09 04:12:18 UTC
I had asked Oyvind about changing the dependency. I didn't get a clear answer as to whether it was ok to make a change to either convert or rsvg. The patch to use rsvg looks good. Should I go ahead and apply the patch then wait to see if there are problems with using rsvg?
Comment 11 Øyvind Kolås (pippin) 2009-03-26 20:37:25 UTC
Being able to generate the documentation perfectly isn't critical so this
patch is fine, it could perhaps be nice to also check for different tools but
this patch is fine with me.
Comment 12 Kevin Cozens 2009-03-27 20:14:19 UTC
2008-03-27  Kevin Cozens  <kcozens@cvs.gnome.org>

        * configure.ac:
        * docs/graphics/Makefile.am: Applied patch from Matteo 'Peach'
        Pescarin which makes build use rsvg binary instead of inkscape
        to create pngs. Fixes bug 571516.