After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571346 - [Win32] Need to set stack size
[Win32] Need to set stack size
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Compilation
git master
Other Windows
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-02-11 20:21 UTC by Morten Welinder
Modified: 2010-04-09 02:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
binary diff pic (98.39 KB, image/jpeg)
2009-12-03 03:33 UTC, sum1 		Details

Description Morten Welinder 2009-02-11 20:21:05 UTC 
It appears that Win32 can blow the stack too.  We need to verify that the
code in gnm_pre_parse_init is actually being compiled-in on windows.
Comment 1 Morten Welinder 2009-02-11 20:38:18 UTC 
For the record, test sheet by the name of "filter_IIR_master.xls" in hand.

Explicit-parentheses nodes took up stack space during eval.  Now fixed.
That saves 10-20% in this case.  Useful, but not enough.
Comment 2 sum1 2009-02-11 23:19:14 UTC 
I set a breakpoint on gnm_pre_parse_init on Windows XP.  Execution stopped at line 200, which is after the HAVE_SYS_RESOURCE_H block:


(gdb) b gnm_pre_parse_init
[...]
Breakpoint 1, gnm_pre_parse_init (argc=1, argv=0x3e5040) at libgnumeric.c:200
        in libgnumeric.c
(gdb) 200       libgnumeric.c: No such file or directory.
Comment 3 Morten Welinder 2009-02-12 21:00:16 UTC 
The sheet in question has a 22k cell cyclic loop. This is very close to
"Doctor, when I bang my head on the wall, it hurts!"
Comment 4 sum1 2009-12-02 02:53:41 UTC 
The crash described in comment 1 (with filter_IIR_master.xls) goes away after running 'editbin.exe /STACK:30000000 gnumeric.exe'.
Comment 5 Morten Welinder 2009-12-02 15:28:52 UTC 
sum1: could you try a binary diff between patched and unpatched binary,
please?
Comment 6 sum1 2009-12-03 03:33:06 UTC 
Created attachment 148980 [details]
binary diff pic

The edited file is on the bottom.
Comment 7 Morten Welinder 2010-04-09 02:30:40 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.