After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571321 - gconfvideo{src,sink} don't disconnect gconf notifications
gconfvideo{src,sink} don't disconnect gconf notifications
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-11 16:58 UTC by Sjoerd Simons
Modified: 2009-02-22 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Disconnect gconf notifications on dispose (2.59 KB, patch)
2009-02-11 17:00 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2009-02-11 16:58:15 UTC 
See topic. This causes empathy to spit out warnings when one opens gstreamer-properties after making a video call.
Comment 1 Sjoerd Simons 2009-02-11 17:00:56 UTC 
Created attachment 128479 [details] [review]
[PATCH] Disconnect gconf notifications on dispose

 ext/gconf/gstgconfvideosink.c |    5 ++++-
 ext/gconf/gstgconfvideosink.h |    3 +++
 ext/gconf/gstgconfvideosrc.c  |    5 ++++-
 ext/gconf/gstgconfvideosrc.h  |    3 +++
 4 files changed, 14 insertions(+), 2 deletions(-)
Comment 2 Guillaume Desmottes 2009-02-16 12:50:07 UTC 
Patch looks good.
Comment 3 Guillaume Desmottes 2009-02-16 12:56:03 UTC 
Oups, I reviwed this patch thinking it was in Empathy. I'm not considering myself as a GStreamer reviewer, sorry. :)
Comment 4 Sebastian Dröge (slomo) 2009-02-22 18:31:31 UTC 
commit ef33cf891f7a9f97f178169adb87aa3695bf9b2b
Author: Sjoerd Simons <sjoerd@luon.net>
Date:   Sun Feb 22 19:30:32 2009 +0100

    gconfvideo(src|sink): Disconnect GConf notifications
    
    Fixes bug #571321.