GNOME Bugzilla – Bug 571294
[matroskamux] Should ignore framerate of 0/1
Last modified: 2009-02-23 11:17:27 UTC
rtpjpegdepay sets it src caps to image/jpeg, framerate=0/1. This causes a matroskamux deeper in the pipeline to report "gst_util_uint64_scale_int: assertion `denom > 0' failed" when it tries to calculate the default frame duration, and to insert a nonsensical default frame duration in the output file. I don't see why a framerate should be set at all by the depayloader, but I've seen others do it as well.
Created attachment 128461 [details] [review] Patch to remove framerate This patch removes the framerate setting completely from the source caps. This wasn't actually made against the git head, I hope it applies cleanly.
I think we use 0/1 to mark a variable framerate instead of a still frame. Idealy matroskamux should handle this framerate as if it was not present.
Created attachment 128974 [details] [review] Patch for matroskamux to ignore framerate==0 OK, this patch for -good makes matroskamux ignore the framerate if it is zero instead. It's not against the git head, so you'll get some fuzziness. Also you need to patch with -p3.
commit b9adb5846bb4d663928e441cf90e1efb75f36630 Author: Arnout Vandecappelle <arnout at mind dot be> Date: Mon Feb 23 12:14:23 2009 +0100 Don't do crazy things with 0/1 framerates We use 0/1 framerates to mark variable framerates and matroskamux should not try to calculate a frame duration for it. Fixes #571294.