After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571192 - Allow windows to scale up when there are multiple workspaces
Allow windows to scale up when there are multiple workspaces
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-02-10 15:23 UTC by Owen Taylor
Modified: 2009-05-05 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Let small windows appear at full size in the overlay if there is room (1.12 KB, patch)
2009-05-05 18:41 UTC, Dan Winship
accepted-commit_now Details | Review

Description Owen Taylor 2009-02-10 15:23:04 UTC
In workspaces.js:

            let size = Math.max(clone.actor.width, clone.actor.height);
            let desiredSize = global.screen_width * fraction;
            let scale = Math.min(desiredSize / size, 1.0);

the Math.min(desireSize, 1.0) is so that if we have a single small window, we don't zoom way in on it ... the idea is to never scale windows up.

But when we have multiple workspaces, then we are already scaling windows down a lot before we start; it seems that we might want to let windows scale up as long as the *absolute* scale factor (relative to the stage) doesn't become greater than 1.

This does allow windows to become more out of proportion to the desktop size, but we already allow a certain amount of disproportionality; I don't think more will hurt.
Comment 1 Dan Winship 2009-05-05 18:41:47 UTC
Created attachment 134052 [details] [review]
Let small windows appear at full size in the overlay if there is room

Previously we forced all windows to shrink at least as much as the
workspace itself did. Now we allow to shrink by a smaller amount (or
not at all) if they'll still fit within their allotted slot.
Comment 2 Owen Taylor 2009-05-05 18:50:23 UTC
Looks good