After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570995 - gstrtph264pay.c fails to build with gcc 4.4.0
gstrtph264pay.c fails to build with gcc 4.4.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.13
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-08 21:31 UTC by Bastien Nocera
Modified: 2009-02-24 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix compiler warnings (861 bytes, patch)
2009-02-10 11:19 UTC, Tim-Philipp Müller 		accepted-commit_now Details | Review

Description Bastien Nocera 2009-02-08 21:31:04 UTC 
0.10.13.2 doesn't build:
http://koji.fedoraproject.org/koji/getfile?taskID=1113738&name=build.log
http://koji.fedoraproject.org/koji/getfile?taskID=1113739&name=build.log

Error is:
cc1: warnings being treated as errors
gstrtph264pay.c: In function 'is_nal_equal':
gstrtph264pay.c:452: error: operation on 'len' may be undefined
gstrtph264pay.c:455: error: operation on 'len' may be undefined
gstrtph264pay.c:459: error: operation on 'len' may be undefined
Comment 1 Tim-Philipp Müller 2009-02-10 11:19:53 UTC 
Created attachment 128366 [details] [review]
fix compiler warnings

Attempt to fix compiler warnings while keeping the code more or less like it is. Untested.
Comment 2 Bastien Nocera 2009-02-10 11:42:21 UTC 
Patch works.

http://koji.fedoraproject.org/koji/getfile?taskID=1116945&name=build.log
Comment 3 Jan Schmidt 2009-02-12 10:34:41 UTC 
In the lack of any more enlightened comments, and given that this patch looks correct to me - please commit it.
Comment 4 Sebastian Dröge (slomo) 2009-02-22 18:25:03 UTC 
ping ;)
Comment 5 Jan Schmidt 2009-02-24 17:38:11 UTC 
Committed, thanks:

commit 8bfffbb0dab1f082e26507ecce2404b686725987
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Feb 24 17:35:46 2009 +0000

    rtp: Fix compiler warning in h264 payloader
    
    Fix an undefined behaviour warning from gcc 4.4.0
    
    Patch By: Tim-Philipp Müller <tim.muller@collabora.co.uk>
    Fixes: #570995
    Signed-Off-By: Jan Schmidt <jan.schmidt@sun.com>