GNOME Bugzilla – Bug 570815
ffmenc_mpeg4 allows its bitrate property to be changed without actually changing the bitrate
Last modified: 2009-04-21 16:39:59 UTC
Please describe the problem: If the pipeline is paused or playing, changing the bitrate has no effect, but the G_OBJECT property for the bitrate is changed regardless. The element should not change this property if the pipeline is in a state > READY and should warn if it can't change it. Steps to reproduce: On a playing or paused pipeline, change the bitrate property on ffenc_mpeg4 with g_object_set and notice that it doesn't actually change, even though the property will be different. Actual results: Expected results: Does this happen every time? yes Other information:
Created attachment 128113 [details] [review] Doesn't change the bitrate if it can't be changed, and issues a warning to that effect.
Created attachment 128114 [details] [review] Doesn't change the bitrate if it can't be changed, and issues a warning to that effect.
Checking against an element's state is tricky, it would be better to check against gstffmpegenc->opened (which is TRUE once we've initialized the ffmpeg encoder).
Created attachment 130098 [details] [review] Proposed patch This patch refuses to change any properties once the ffmpeg encoder is setup.
commit f07223fd248ef22937afc7bef85fb89b3d5cdc24 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Apr 21 18:38:03 2009 +0200 gstffmpegenc: Don't change properties once opened. Fixes #570815 Based on a patch by Tristan Matthews <le businessman at gmail dot com>