After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570797 - gtk_activatable_reset has a very generic name
gtk_activatable_reset has a very generic name
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-02-06 16:00 UTC by Torsten Schoenfeld
Modified: 2009-03-03 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Torsten Schoenfeld 2009-02-06 16:00:19 UTC 
gtk_activatable_reset() has a very generic name for an interface method.  In language with some support for OO it will be wrapped as a method named just reset().  This has a lot of potential for conflicting with other methods in the hierarchy, and for confusing the reader.  All the other GtkActivatable methods carry "action" in their name, making conflicts much less likely.  Can gtk_activatable_reset() be renamed to, say, gtk_activatable_reset_action()?
Comment 1 Christian Dywan 2009-02-20 20:36:59 UTC 
I second that concern. Not only for the sake of object oriented languages but also for consistency and clarity of the API.
Comment 2 Torsten Schoenfeld 2009-03-03 17:27:53 UTC 
Matthias fixed this by renaming gtk_activatable_reset to gtk_activatable_sync_action_properties with r22389.