After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570752 - Deregistering an application leaves a dangling pointer
Deregistering an application leaves a dangling pointer
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: atkbridge
1.25.x
Other All
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2009-02-06 05:11 UTC by Mike Gorse
Modified: 2009-02-06 05:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Proposed patch. (867 bytes, patch)
2009-02-06 05:15 UTC, Mike Gorse 		committed Details | Review

Description Mike Gorse 2009-02-06 05:11:08 UTC 
Please describe the problem:
There is a global variable, called registry, which holds a reference to the registry.  It appears that deregister_application is intended to set this variable to NULL, but this does not happen because the function defines a local variable called registry.  This can result in a crash because the global variable now points to unallocated memory.


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Mike Gorse 2009-02-06 05:15:27 UTC 
Created attachment 128075 [details] [review]
Proposed patch.

Simply removing the local variable might also work, although we might need a null check if we were to do that instead.