GNOME Bugzilla – Bug 570736
Without PulseAudio there is no way to edit sound theme configuration
Last modified: 2009-03-04 22:54:25 UTC
I notice that gnome-control-center removed the sound capplet because it was moved to gnome-media. However, looking at gnome-media it seems that the ability to configure sounds was added to the new gnome-volume-control submodule. This is only build if PulseAudio is on the system. So, for systems which do not have PulseAudio, is there no longer a way to configure the system event sounds or theme? Perhaps this should be added back to control-center, and turned off by default so that systems without PulseAudio can continue using the old capplet? Or is there a different suggestion? Perhaps I'm missing something.
We certainly don't want to maintain to capplets in parallel. The sound events stuff doesn't really have anything to do with PA, so it might be possible to build it even if PA isn't available. Moving to gnome-media...
I don't think it matters if the solution is provided by gnome-control-center or via gnome-media. I would appreciate some guidance from the gnome-media maintainers about how users without PulseAudio should be able to edit the sound theme configuration. Perhaps a possible solution would be to enhance gnome-volume-control so that it has similar functionality to edit theme configuration that now exists in gnome-volume-control? Or is there a better approach?
Created attachment 129982 [details] [review] patch resolving issue I wrote the attached patch as a proof-of-concept. With this patch it is fairly easy to build the new theme configuration widget into gst-mixer. With this patch there is a new tab called "Sound Theme" which shows the same dialog that is in g-v-c. This is about 75% done. To finish this work, it would probably be good to move the gvc-sound-theme-chooser.[ch] and sound-theme-file-utils.[ch] files into a common directory on the toplevel and build a static library that both gst-mixer and gnome-volume-control could share. This directory would only be built if libcanberra is present and if either gst-mixer or gnome-volume-control is configured to build. Note that for this to work properly, the sound files in the directory gnome-volume-control/data/sounds should also be installed in either case, so this directory should probably also be moved into this common directory. I would be happy to finish this as I suggest, but I wanted to get feedback before doing that work. Thanks.
Created attachment 130067 [details] [review] patch fixing issue. Here is an updated patch which resolves the issue more cleanly. It is applied upstream now, so this bug is fixed. It builds the theme code in the sound-theme directory, and this is linked into both gst-mixer and gnome-volume-control so that both programs can provide theme editing features. In gst-mixer, a new tab is added which displays this widget.
The maintainers telling you you can commit patches to gst-mixer doesn't mean you can break the rest. - You're not using libtool libraries - The libraries created are full of undefined symbols because they're not linked to anything - And don't use -l to link to a static library... And don't use "../../" in Makefile.ams, this fails with srcdir != builddir. That'll be fixed shortly in trunk. Don't commit anything else that touches anything but gst-mixer.
And you didn't have the changelog for gnome-volume-control changes in the right ChangeLog. Look for prepare-ChangeLog.pl instead of doing it by hand.
Bastien, apologies. I didn't mean to make things a pain. That was the only fix that I wanted to make that was outside of gst-mixer so I won't be changing any other code outside of the gst-mixer directory.