After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570581 - osxvideosink: non-embedded mode is badly broken and should be removed
osxvideosink: non-embedded mode is badly broken and should be removed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Mac OS
: Normal normal
: 0.10.14
Assigned To: Michael Smith
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-05 01:00 UTC by Michael Smith
Modified: 2009-03-07 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove non-embedded mode, fix use of autorelease pools (19.27 KB, patch)
2009-02-05 01:01 UTC, Michael Smith 		none Details | Review

Description Michael Smith 2009-02-05 01:00:12 UTC 
The default mode for osxvideosink is for it to create its own window. This does not (and can not) work for any cocoa application - the sole purpose appears to be to make it usable with gst-launch.

However, those codepaths are complex, mostly untested, and painful to maintain.

The patch I'm about to attach removes this mode, and makes the embedded mode mandatory. It also fixes memory management to avoid leaks and occasional crashes.

What do people think about this? Has anyone actually made real use of osxvideosink without using the embedded mode?

(oleavr and twi seemed to give their approval for this idea on irc the other day, so I'll commit this in a week or so if nobody objects)
Comment 1 Michael Smith 2009-02-05 01:01:38 UTC 
Created attachment 127980 [details] [review]
Remove non-embedded mode, fix use of autorelease pools
Comment 2 David Schleef 2009-02-05 01:18:17 UTC 
That was one of my immediate thoughts looking at the code a few weeks ago.  x[v]imagesink work on OS/X without much trouble (assuming you're compiling gstreamer from scratch), so anyone using gst-launch can use those.
Comment 3 Sjoerd Op 't Land 2009-03-07 09:52:15 UTC 
Might it be of use to throw an error message for gst-launch users (that'd me ;) ) that the non-embedded is not supported anymore?