After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570457 - Move PIN selection to a separate dialogue
Move PIN selection to a separate dialogue
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: wizard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-02-04 03:45 UTC by Vincent Untz
Modified: 2009-03-05 00:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (6.66 KB, patch)
2009-02-04 03:46 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2009-02-04 03:45:36 UTC 
Here's a patch that implements what Bastien proposed in http://thread.gmane.org/gmane.linux.bluez.kernel/717/focus=721

I didn't put the "Force a random PIN number" option -- I wasn't sure it was that useful.

At some point, I considered putting all this in a new page of the assistant, but I'm not a big fan of one more click.

(wasn't quite sure how to name the functions: I tried to keep something consistent with what was already done, but that's not my usual style, so I probably failed ;-))
Comment 1 Vincent Untz 2009-02-04 03:46:01 UTC 
Created attachment 127898 [details] [review]
Patch
Comment 2 Vincent Untz 2009-02-04 03:47:23 UTC 
(oops, three lines are using spaces instead of tabs)
Comment 3 Bastien Nocera 2009-02-04 11:19:06 UTC 
Please send the patch upstream to the linux-bluetooth mailing-list, thanks.
Comment 4 Andrey 2009-02-25 02:37:33 UTC 
As I can see, patch has been posted in the mailing list:

http://article.gmane.org/gmane.linux.bluez.kernel/1399

Are there any news ? Sorry for pushing but about 20 bugs for bluez-gnome are open only because of this issue.
Comment 5 Bastien Nocera 2009-02-25 14:51:09 UTC 
Reassigning to bluez-gnome fork, gnome-bluetooth.
Comment 6 Bastien Nocera 2009-02-25 16:10:50 UTC 
I've committed this patch, but we should really move it to another dialogue. Something like "Passkey Options..." would allow the selection.