After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570298 - When renaming files, the %artist% placeholder should refer to the album artist
When renaming files, the %artist% placeholder should refer to the album artist
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Metadata
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 557608 587532 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-02-03 00:58 UTC by John Millikin
Modified: 2009-07-01 21:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add %album_artist% placeholder (2.86 KB, patch)
2009-02-03 02:05 UTC, John Millikin
needs-work Details | Review
Add %album_artist% placeholder, modify %artist% (3.94 KB, patch)
2009-02-04 22:41 UTC, John Millikin
none Details | Review
Add %album_artist% placeholder, modify %artist% (v3) (5.90 KB, patch)
2009-02-04 22:57 UTC, John Millikin
committed Details | Review

Description John Millikin 2009-02-03 00:58:48 UTC
Otherwise, when updating the metadata in compilation albums, the album will be split across multiple directories.
Comment 1 John Millikin 2009-02-03 02:05:12 UTC
Created attachment 127806 [details] [review]
Add %album_artist% placeholder

Adds the ``ITrackInfo.DisplayAlbumArtistName`` property, akin to ``DisplayArtistName``. Adds a new placeholder, %album_artist%, and modifies the album templates to use it rather than %artist%.
Comment 2 Gabriel Burt 2009-02-04 22:17:51 UTC
Adding album_artist is good, but I think we should have it also be an alias for artist, and change what is now called artist to track_artist.

This is a separate/bigger issue, but we should have a much more customizable pattern editor, and have some smartness that takes care of multi-disc albums appropriately, possibly different patterns for compilations (eg albumartist/album/01 - track_artist - title.mp3 where the track_artist - part wouldn't be there for a non-compilation).  Any way, sorry, separate issue, just brain dumping.
Comment 3 John Millikin 2009-02-04 22:21:45 UTC
> Adding album_artist is good, but I think we should have it also be an alias for
> artist, and change what is now called artist to track_artist.

That was my first thought at first, hence the bug title. But it conflicts with the terminology used for metadata elsewhere in Banshee, including the user interface and track metadata properties.
Comment 4 Gabriel Burt 2009-02-04 22:30:08 UTC
Change the terminology to Album Artist, but leave the identifier "artist".  The user doesn't see that key/name any way, they only see the label.
Comment 5 John Millikin 2009-02-04 22:41:50 UTC
Created attachment 127965 [details] [review]
Add %album_artist% placeholder, modify %artist%

> Adding album_artist is good, but I think we should have it also be an alias for
> artist, and change what is now called artist to track_artist.

> Change the terminology to Album Artist, but leave the identifier "artist".

Done and done
Comment 6 John Millikin 2009-02-04 22:57:41 UTC
Created attachment 127968 [details] [review]
Add %album_artist% placeholder, modify %artist% (v3)

> It would also be nice to update the pattern descriptions in LibrarySchema.cs
> while you're at that, rename the "Artist" label to "Track Artist"
Comment 7 Gabriel Burt 2009-02-04 23:40:38 UTC
Thanks a lot John, committed.
Comment 8 John Millikin 2009-03-04 02:24:43 UTC
*** Bug 557608 has been marked as a duplicate of this bug. ***
Comment 9 Bertrand Lorentz 2009-07-01 21:15:27 UTC
*** Bug 587532 has been marked as a duplicate of this bug. ***