After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570275 - Does not ignore some generated files
Does not ignore some generated files
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other All
: Normal minor
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2009-02-02 21:19 UTC by Matt Kraai
Modified: 2010-05-03 02:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Patch (1.60 KB, patch)
2009-02-02 21:28 UTC, Matt Kraai
needs-work Details | Review
"git status" output (4.26 KB, application/octet-stream)
2010-05-02 23:22 UTC, Matt Kraai
  Details
Ignore generated files (1.50 KB, patch)
2010-05-02 23:35 UTC, Matt Kraai
reviewed Details | Review

Description Matt Kraai 2009-02-02 21:19:22 UTC
Please describe the problem:
Subversion is not configured to ignore some of the files generated during a build.

Steps to reproduce:
1. svn checkout http://svn.gnome.org/svn/metacity/trunk/ metacity
2. cd metacity
3. ./autogen.sh
4. make
5. svn status


Actual results:
"svn status" displays the following:

 ?      gnome-doc-utils.make
 ?      src/metacity-wm.desktop
 ?      src/metacity.schemas.in
 ?      src/schema_bindings
 ?      doc/creating_themes/Makefile.in
 ?      doc/creating_themes/Makefile


Expected results:
"svn status" to display nothing.

Does this happen every time?
Yes.

Other information:
Comment 1 Matt Kraai 2009-02-02 21:28:28 UTC
Created attachment 127790 [details] [review]
Patch
Comment 2 Thomas Thurman 2010-05-02 15:10:06 UTC
Comment on attachment 127790 [details] [review]
Patch

Three things:

1) I'm really sorry this bug dropped off the radar.  Life has been pretty busy, but that's no excuse.

2) This doesn't appear to be a patch.  Or if it's some kind of patch I haven't run into, I don't know how to apply it.

3) We're not using svn any more.  Do you know whether the issue remains with git?
Comment 3 Matt Kraai 2010-05-02 23:22:24 UTC
Hi Thomas,

(In reply to comment #2)
> (From update of attachment 127790 [details] [review])
> Three things:
> 
> 1) I'm really sorry this bug dropped off the radar.  Life has been pretty busy,
> but that's no excuse.
> 
> 2) This doesn't appear to be a patch.  Or if it's some kind of patch I haven't
> run into, I don't know how to apply it.

Yes, it's definitely not standard.  Unfortunately, that's what "svn diff" produced when I invoked it to determine what properties I'd changed.

> 3) We're not using svn any more.  Do you know whether the issue remains with
> git?

It does.  I'll attach the output of "git status" after running "git clone git://git.gnome.org/metacity && cd metacity && ./autogen.sh && make" shortly.
Comment 4 Matt Kraai 2010-05-02 23:22:58 UTC
Created attachment 160176 [details]
"git status" output
Comment 5 Thomas Thurman 2010-05-02 23:32:35 UTC
Looks good.  Committed.
Comment 6 Thomas Thurman 2010-05-02 23:32:56 UTC
(Oh, and thanks!)
Comment 7 Matt Kraai 2010-05-02 23:35:18 UTC
Created attachment 160177 [details] [review]
Ignore generated files
Comment 8 Thomas Thurman 2010-05-02 23:48:44 UTC
Review of attachment 160177 [details] [review]:

Is this different from the patch that just went into master from your previous attachment?
Comment 9 Matt Kraai 2010-05-03 02:37:46 UTC
(In reply to comment #8)
> Review of attachment 160177 [details] [review]:
> 
> Is this different from the patch that just went into master from your previous
> attachment?

Yes, but it's mostly just future-proofing (e.g., ignoring po/*.gmo or *.o, so that new .gmo and .o files are automatically ignored).