After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570226 - clearing a tracker does not update automatic hints
clearing a tracker does not update automatic hints
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
2.24.x
Other Linux
: Normal minor
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-02 15:00 UTC by Josselin Mouette
Modified: 2010-04-12 21:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Centralize update_all_hints() call (2.46 KB, patch)
2010-03-27 06:23 UTC, Jim Ross
committed Details | Review
Centralize update_all_hints() call (3.50 KB, patch)
2010-03-29 05:41 UTC, Jim Ross
none Details | Review

Description Josselin Mouette 2009-02-02 15:00:05 UTC
[ Original report by Brian M. Carlson : http://bugs.debian.org/512890 ]

If "Always show hint" is on and I clear a tracker, the hints are not
updated until I hit a key.  They should be updated by clearing a
tracker.  This isn't a big deal because using 0 as the key is
effectively a no-op that updates hints, but it still would be nice to
have fixed.
Comment 1 Jim Ross 2010-03-27 06:23:14 UTC
Created attachment 157252 [details] [review]
Centralize update_all_hints() call

This is a problem for clear, clear trackers, and clear others.  Basically any clear operation.  

This patch centralizes the update_all_hints() call, moving it into SudokuGameDisplay's add_value() and remove() methods.
Comment 2 Jim Ross 2010-03-29 05:41:41 UTC
Created attachment 157350 [details] [review]
Centralize update_all_hints() call

bah.  Sorry - that last patch was based on some other fixes I've been working on.  This new patch is based on what's currently in the main repository.
Comment 3 Thomas Andersen 2010-04-12 19:37:32 UTC
Comment on attachment 157252 [details] [review]
Centralize update_all_hints() call

Committed to master:
http://git.gnome.org/browse/gnome-games/commit/?id=92237d68274d946a5eb93879044eef19f927d2f1

Had to go with the first patch since the other fixes you mention already went in :)
Comment 4 Jim Ross 2010-04-12 21:20:18 UTC
cool