After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569673 - [Mpegtsparse] PAT changes not always signaled
[Mpegtsparse] PAT changes not always signaled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.10
Other All
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-29 13:46 UTC by Vincent Génieux
Modified: 2009-05-03 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.63 KB, patch)
2009-01-29 13:48 UTC, Vincent Génieux
none Details | Review
Small sample test file with only PAT changes (no video streams) (170.38 KB, application/octet-stream)
2009-01-29 13:53 UTC, Vincent Génieux
  Details

Description Vincent Génieux 2009-01-29 13:46:18 UTC
Please describe the problem:
While reading a MPTS file, there is some cases where PAT changes are not always signals (via a gst_post_message).


Steps to reproduce:
1. take 2 MPTS file stream (recorded from a dvb device)
2. Use a MPTS file which mix 2 MPTS stream. A such file can be created with dd :  dd bs=188 count=100000 if=stream1.ts of=mix.ts ; dd bs=188 count=100000 if=stream2.ts >> mix.ts ; dd bs=188 count=100000 if=stream1.ts >> mix.ts
3. run the following command: gst-launch -m filesrc location=mix.ts ! mpegtsparse | grep pat


Actual results:
There are only two pat changes reported. There should be three : one for each part of the file.
In fact the last pat change (when mpegtsparse is back to the stream1) is ignored.

Expected results:
There should be three PAT announcement.

Does this happen every time?
yes

Other information:
In fact, subtables are decoded for the PAT table which doesn't make sense.
A proposed patch inhibits the subtable mechanism when parsing the PAT.

It also clean mpegtspacketizer stream's structure when streams are out of date (on pat change).

Note: I can send a mix.ts file on demand.
Comment 1 Vincent Génieux 2009-01-29 13:48:03 UTC
Created attachment 127459 [details] [review]
proposed patch

inhibit subtable mechanism for PAT parsing
clean mpegpacketizer cache when a pmt is not in the PAT anymore.
Comment 2 Vincent Génieux 2009-01-29 13:53:08 UTC
Created attachment 127461 [details]
Small sample test file with only PAT changes (no video streams)
Comment 3 Vincent Génieux 2009-03-17 09:45:06 UTC
hello, any news about this bug ?
Comment 4 Zaheer Abbas Merali 2009-05-03 16:34:00 UTC
Thanks for the patch.

commit e41401e3174b80b2e2ce4febf99f15e766dfc5c6
Author: Vincent Genieux <mutex@runbox.com>
Date:   Sun May 3 17:42:44 2009 +0100

    mpegtsparse: Ignore subtable extension when parsing PAT
    
    Fixes #569673.