After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569374 - Logging exceptions from tweener callbacks could be better
Logging exceptions from tweener callbacks could be better
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2009-01-27 18:47 UTC by Tommi Komulainen
Modified: 2009-01-27 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tweener: use logError() to log exceptions from callbacks (958 bytes, patch)
2009-01-27 18:47 UTC, Tommi Komulainen 		committed Details | Review

Description Tommi Komulainen 2009-01-27 18:47:26 UTC 
When tweener callbacks (onComplete, onStart, etc.) throw exceptions, all you
get to the log is the exception message, e.g.

    Error calling onComplete: [exception message]

Using logError() we could get also the backtrace logged, making debugging much
easier.
Comment 1 Tommi Komulainen 2009-01-27 18:47:29 UTC 
Created attachment 127345 [details] [review]
tweener: use logError() to log exceptions from callbacks

Makes log messages much more useful when they include the backtrace and
not just the callback name (e.g. 'onComplete')
Comment 2 Johan Bilien 2009-01-27 18:59:46 UTC 
yes!
Comment 3 Tommi Komulainen 2009-01-27 19:20:04 UTC 
Committed as r153