After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569183 - F-spot CDExport dialog exceed 600 pixel height when the screen is small
F-spot CDExport dialog exceed 600 pixel height when the screen is small
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.5.x
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-26 12:36 UTC by Pedro Villavicencio
Modified: 2009-07-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (attached) (1.29 KB, patch)
2009-02-23 13:13 UTC, Alexander Sack 		none Details | Review

Description Pedro Villavicencio 2009-01-26 12:36:28 UTC 
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/f-spot/+bug/320817

"In the process of developing the Ubuntu Netbook Remix, with the smaller screens of netbooks in mind, I wrote a patch to make f-spot work with less pixels.

The problem is when exporting an image to CD, the dialog will exceed 600 pixel height.
It can be easily reproduced by
1. Xephyr -ac -screen 1024x600 :2
2. env DISPLAY=:2 metacity &
3. env DISPLAY=:2 f-spot
4. Select an image in f-spot and export it to CD

How interested are you in making such a resolution-dependent change?
Thanks."

"

Patch:

http://launchpadlibrarian.net/21593846/10_1024x600_CDExport.cs.dpatch
Comment 1 Alexander Sack 2009-02-23 13:13:09 UTC 
Created attachment 129317 [details] [review]
patch (attached)

attaching the patch directly (not folded=
Comment 2 Sebastien Bacher 2009-03-03 09:27:58 UTC 
could somebody review this change?
Comment 3 Alexander Sack 2009-06-09 14:28:31 UTC 
gentle prodding. anyone up for a review?
Comment 4 Maxxer 2009-07-14 16:49:13 UTC 
thanks for your patch, but a different approach has been commited

commit b0686f0f0da54e030fcbfd3ebe15ec430e7c0126
Author: Lorenzo Milesi <maxxer@yetopen.it>
Date:   Tue Jul 14 00:00:30 2009 +0200

    CDExport: move to GtkBuilder
    
    * Reduced window height, to fit netbooks (<600px)
    * Export button translatable