GNOME Bugzilla – Bug 569100
when brightness is to 0, pressing one more brightness down makes brightness up/down stop working.
Last modified: 2009-02-08 14:53:56 UTC
Please describe the problem: hello, after reporting some bugreport because the brightness don't work correctly, there was a brightness kernel patch that was made. in the same time, the manufacturer upload a new bios that does the same as the kernel patch (the brightness key didn't send release event) now we found an other problem indeed when pressing the brightness key a long time, nether brightness up and brightness down worked anymore :( when brightness was set to 0 and we press brightness down, it is like the brightness keys are disable the only way to make them work again is to restart gnome in my case i use xfce, who also use gnome-power-manager, and the problem is the same. An other user, who use ivman did not have that problem this problem is on the samsung NC10 netbook Steps to reproduce: 1. having an nc10 with last bios or the kernel keyboard patch 2. pressing brightness down to total dark screen 3. having a useless computer because you can't see anything anymore ... Actual results: screen goes black, with no possibility to restore it without restarting gnome-power-manager Expected results: screen should go black, with possibility to brightness it up again Does this happen every time? yes Other information:
everything goes well here... same notebook
I can confirm, sorry I've double checked. Same problem.
Same problem here too. At the moment I'm using a keys combination bind to recover screen brightness when stuck, launching the command "killall gnome-power-manager && gnome-power-manager".
hum i really would like to know if this kind of bug is general or only with samsung nc10 .... thanks Fortunato for your trick i think i'll do the same as long as gpm is not correct
I've written a patch for gpm that seems to fix the problem. It works for me, please let me know if there is any problem with it.
Created attachment 127370 [details] [review] brightness-down-fix.patch
Applied to 2-24 and trunk: 2009-01-28 Richard Hughes <richard@hughsie.com> * src/gpm-brightness-xrandr.c: (gpm_brightness_xrandr_output_down): When the minimum reported brightness is not zero don't wraparound 0 when we try to step down a large number of brightness levels. Instead truncate to the minimum to fix a hang. Fixes #569100 Patch from Fortunato Ventre, many thanks.
i can't test it right now but i hope i can test it before tomorrow but the code seems to be logical (for once i understand what is done :) )
it was longer than i expected, but i finaly tried your patch i confirm, thant with this patch there is no more problem.