After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569100 - when brightness is to 0, pressing one more brightness down makes brightness up/down stop working.
when brightness is to 0, pressing one more brightness down makes brightness u...
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
2.24.x
Other All
: Normal major
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-01-25 17:35 UTC by alain57@gmail.com
Modified: 2009-02-08 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
brightness-down-fix.patch (740 bytes, patch)
2009-01-28 02:13 UTC, Fortunato Ventre
none Details | Review

Description alain57@gmail.com 2009-01-25 17:35:36 UTC
Please describe the problem:
hello,
after reporting some bugreport because the brightness don't work correctly, there was a brightness kernel patch that was made.
in the same time, the manufacturer upload a new bios that does the same as the kernel patch (the brightness key didn't send release event)

now we found an other problem
indeed when pressing the brightness key a long time, nether brightness up and brightness down worked anymore :(

when brightness was set to 0 and we press brightness down, it is like the brightness keys are disable

the only way to make them work again is to restart gnome

in my case i use xfce, who also use gnome-power-manager, and the problem is the same.

An other user, who use ivman did not have that problem


this problem is on the samsung NC10 netbook

Steps to reproduce:
1. having an nc10 with last bios or the kernel keyboard patch
2. pressing brightness down to total dark screen
3. having a useless computer because you can't see anything anymore ...


Actual results:
screen goes black, with no possibility to restore it without restarting gnome-power-manager

Expected results:
screen should go black, with possibility to brightness it up again

Does this happen every time?
yes

Other information:
Comment 1 Andrea Cimitan 2009-01-25 18:08:51 UTC
everything goes well here... same notebook
Comment 2 Andrea Cimitan 2009-01-25 23:12:51 UTC
I can confirm, sorry I've double checked.
Same problem.
Comment 3 Fortunato Ventre 2009-01-26 09:54:07 UTC
Same problem here too.

At the moment I'm using a keys combination bind to recover screen brightness when stuck, launching the command "killall gnome-power-manager && gnome-power-manager".
Comment 4 alain57@gmail.com 2009-01-26 10:10:24 UTC
hum i really would like to know if this kind of bug is general or only with samsung nc10 ....
thanks Fortunato for your trick i think i'll do the same as long as gpm is not correct
Comment 5 Fortunato Ventre 2009-01-28 02:12:48 UTC
I've written a patch for gpm that seems to fix the problem. It works for me, please let me know if there is any problem with it.
Comment 6 Fortunato Ventre 2009-01-28 02:13:50 UTC
Created attachment 127370 [details] [review]
brightness-down-fix.patch
Comment 7 Richard Hughes 2009-01-28 08:44:37 UTC
Applied to 2-24 and trunk:

2009-01-28  Richard Hughes  <richard@hughsie.com>

	* src/gpm-brightness-xrandr.c: (gpm_brightness_xrandr_output_down):
	When the minimum reported brightness is not zero don't wraparound 0
	when we try to step down a large number of brightness levels.
	Instead truncate to the minimum to fix a hang.
	Fixes #569100
	Patch from Fortunato Ventre, many thanks.
Comment 8 alain57@gmail.com 2009-01-28 09:12:42 UTC
i can't test it right now
but i hope i can test it before tomorrow
but the code seems to be logical (for once i understand what is done :) )
Comment 9 alain57@gmail.com 2009-02-08 14:53:56 UTC
it was longer than i expected, but i finaly tried your patch

i confirm, thant with this patch there is no more problem.