After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569066 - gvfs' configure.ac uses non posix 'test' constructions
gvfs' configure.ac uses non posix 'test' constructions
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
1.0.x
Other FreeBSD
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 567287 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-01-25 12:13 UTC by Alexis Ballier
Modified: 2009-03-02 12:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
trunk patch (3.16 KB, patch)
2009-01-25 12:14 UTC, Alexis Ballier
committed Details | Review
1.0.3 patch (3.32 KB, patch)
2009-01-25 12:15 UTC, Alexis Ballier
none Details | Review

Description Alexis Ballier 2009-01-25 12:13:49 UTC
There is such things in configure.ac:
if test "x$msg_http" == "xyes"; then

but according to:
http://www.opengroup.org/onlinepubs/9699919799/utilities/test.html

== isn't a valid construction, while = is.

This causes build failures later on FreeBSD because HTTP_CFLAGS doesn't contain the libsoup one's and thus fails to include correctly the headers.

I'll attach a patch against 1.0.3 and trunk.
Comment 1 Alexis Ballier 2009-01-25 12:14:15 UTC
Created attachment 127193 [details] [review]
trunk patch
Comment 2 Alexis Ballier 2009-01-25 12:15:04 UTC
Created attachment 127194 [details] [review]
1.0.3 patch
Comment 3 Alexander Larsson 2009-03-02 11:04:39 UTC
Fixed on trunk.
Comment 4 Alexander Larsson 2009-03-02 12:25:23 UTC
*** Bug 567287 has been marked as a duplicate of this bug. ***