After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568900 - show recording applications, too
show recording applications, too
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-23 19:00 UTC by Matthias Clasen
Modified: 2009-02-10 18:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gvc-show-recording-apps.patch (1.98 KB, patch)
2009-02-10 16:08 UTC, Bastien Nocera 		committed Details | Review
Screenshot-Sound Preferences.png (17.29 KB, image/png)
2009-02-10 16:10 UTC, Bastien Nocera 		  Details

Description Matthias Clasen 2009-01-23 19:00:31 UTC 
Currently the applications tab only shows playing applications. I think for completeness, it should also show recording applications, using the microphone icon instead of the speaker.
Comment 1 Bastien Nocera 2009-02-10 16:08:45 UTC 
Created attachment 128386 [details] [review]
gvc-show-recording-apps.patch

Patch to do that.
Comment 2 Bastien Nocera 2009-02-10 16:10:43 UTC 
Created attachment 128387 [details]
Screenshot-Sound Preferences.png

What it looks like.

And it correctly changes the icon when the application plays rather than records.
Comment 3 Bastien Nocera 2009-02-10 16:14:24 UTC 
2009-02-10  Bastien Nocera  <hadess@hadess.net>

        * src/gvc-mixer-control.c (update_source_output):
        * src/gvc-mixer-dialog.c (add_stream): Show recording applications
        in addition to playback applications, use the microphone icon
        for those applications (Closes: #568900)
Comment 4 Matthias Clasen 2009-02-10 18:01:31 UTC 
Now that thats done (thanks!), we should probably adjust the placeholder text to say "No application is currently playing or recording".
Comment 5 Bastien Nocera 2009-02-10 18:05:46 UTC 
2009-02-10  Bastien Nocera  <hadess@hadess.net>

        * src/gvc-mixer-dialog.c (gvc_mixer_dialog_constructor):
        Correct the label to mention that there are no recording apps as well
        (Closes: #568900)