GNOME Bugzilla – Bug 568837
RFE: allow building against the system modplug library
Last modified: 2009-01-24 17:15:29 UTC
It would be nice if the modplug plugin could be built against a system version of the library instead of the included copy. I'll attach a proof of concept patch, it works, but it makes the change to using a system modplug library unconditionally. I'm afraid my autofoo isn't all that good.
Created attachment 127093 [details] [review] proof of concept patch Ignore the version in the filename, I've been carrying this patch for a while (didn't submit because it is not finished), it has been rebased against 0.10.10 .
commit bf7ccbe0f8fd834ef186e5c266e40acaadf5536d Author: Hans de Goede <jwrdegoede@fedoraproject.org> Date: Sat Jan 24 18:13:39 2009 +0100 Build the modplug plugin against the modplug library and remove our copy Always build the modplug plugin against the system modplug library and remove our own copy. Using the system version has advantages if security issues or other critical bugs are found in libmodplug and our own copy wasn't really maintained anyway. Also our copy only contained some patches to use GLib types and functions. Fixes bug #568837.