After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568837 - RFE: allow building against the system modplug library
RFE: allow building against the system modplug library
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.10
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-23 13:52 UTC by Hans de Goede
Modified: 2009-01-24 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proof of concept patch (2.51 KB, patch)
2009-01-23 13:57 UTC, Hans de Goede 		committed Details | Review

Description Hans de Goede 2009-01-23 13:52:26 UTC 
It would be nice if the modplug plugin could be built against a system version of the library instead of the included copy.

I'll attach a proof of concept patch, it works, but it makes the change to using a system modplug library unconditionally. I'm afraid my autofoo isn't all that good.
Comment 1 Hans de Goede 2009-01-23 13:57:39 UTC 
Created attachment 127093 [details] [review]
proof of concept patch

Ignore the version in the filename, I've been carrying this patch for a while (didn't submit because it is not finished), it has been rebased against 0.10.10 .
Comment 2 Sebastian Dröge (slomo) 2009-01-24 17:15:29 UTC 
commit bf7ccbe0f8fd834ef186e5c266e40acaadf5536d
Author: Hans de Goede <jwrdegoede@fedoraproject.org>
Date:   Sat Jan 24 18:13:39 2009 +0100

    Build the modplug plugin against the modplug library and remove our copy
    
    Always build the modplug plugin against the system modplug library
    and remove our own copy. Using the system version has advantages
    if security issues or other critical bugs are found in libmodplug
    and our own copy wasn't really maintained anyway.
    
    Also our copy only contained some patches to use GLib types and functions.
    Fixes bug #568837.