GNOME Bugzilla – Bug 568713
g-s-d xrandr plugin crashes in handle_fn_f7 because of wrong error handling
Last modified: 2009-01-24 13:14:07 UTC
g-s-d does if (!gnome_rr_screen_refresh (screen, &error){ str = g_strdup_printf (_("Could not refresh the screen information: %s"), error->message); in handle_fn_f7 but the documentation of gnome_rr_screen_refresh states: Returns : TRUE if the screen's configuration changed; otherwise, the function returns FALSE and a NULL error if the configuration didn't change, or FALSE and a non-NULL error if there was an error while refreshing the configuration. Though this error gets dereferenced while beeing NULL. Thanks, Andres
Created attachment 127006 [details] [review] Simple fix for the error handling issue. This fixes the issue locally for me (ubuntu jaunty).
Thanks! 2009-01-24 Jens Granseuer <...> Patch by: Andres Freund <...> Fix possible crash when pressing Fn-F7 (bug #568713) * plugins/xrandr/gsd-xrandr-manager.c: (handle_fn_f7): only try to dereference the error when it was actually set
*** Bug 566287 has been marked as a duplicate of this bug. ***