After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568481 - GStreamer linking failures.
GStreamer linking failures.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other opensolaris
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-20 20:53 UTC by Brian Cameron
Modified: 2009-01-23 08:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
patch (1.10 KB, patch)
2009-01-20 20:54 UTC, Brian Cameron 		needs-work Details | Review
updated patch (978 bytes, patch)
2009-01-23 04:39 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2009-01-20 20:53:38 UTC 
Several GStreamer libraries fail to build on Solaris due to missing -lm, -lsocket, and/or -lnsl libraries on the link line.  

This patch fixes GStreamer so it builds.  Not sure if this patch needs additional work to go upstream.
Comment 1 Brian Cameron 2009-01-20 20:54:06 UTC 
Created attachment 126866 [details] [review]
patch
Comment 2 David Schleef 2009-01-20 22:04:58 UTC 
We obviously can't use Solaris-only libraries unconditionally.
Comment 3 Brian Cameron 2009-01-20 22:27:02 UTC 
Understood.  I just wasn't sure how this would be be handled in configure.  Do you have any suggestions?  I'm happy to update this patch based on any advice on how to best fix the problem.
Comment 4 Brian Cameron 2009-01-23 04:39:23 UTC 
Created attachment 127061 [details] [review]
updated patch


This updated patch fixes configure to check for libsocket and libnsl, so the libraries get added to LIBS if present on the system.  This seems cleaner and hopefully can go upstream.

Also note the gst//Makefile.am needs to also be updated to link with LIBM since it uses libm math functions.
Comment 5 Sebastian Dröge (slomo) 2009-01-23 08:58:58 UTC 
commit 0bf1bd0db059b5e2e51e9293cea72cfb557ac567
Author: Brian Cameron <brian.cameron@sun.com>
Date:   Fri Jan 23 09:54:53 2009 +0100

    Fix linking failures on Solaris. Fixes bug #568481.
    
    Link libgstreamer with $(LIBM) as it uses math functions.
    
    Add a configure check for socket and nsl library and add
    them to LIBS if they're found. This is needed on Solaris
    for socket() and gethostbyname().