GNOME Bugzilla – Bug 568480
gst-plugins-bad dccp plugin won't compile on Soalris
Last modified: 2009-01-23 09:14:12 UTC
On Solaris, there is no msg_control or msg_controllen is the msghdr struture. The attached patch fixes gst-plugins-bad so it will build on Solaris.
Created attachment 126864 [details] [review] patch fixing dccp plugin so it builds
We need a configure check for those libraries as they're only available on Solaris. Also, instead of the configure check you added you could simply memset() the struct to 0 before using it instead of setting those fields in an #ifdef. The check is fine too though :)
Created attachment 127059 [details] [review] updated patch Note the code already memsets the structure to 0, so the updated patch just removes the redundant places where the code was setting it to 0 again.
commit 486d76b4544ee9d2c4cf6ab5730f0f12c422a6d0 Author: Brian Cameron <brian.cameron@sun.com> Date: Fri Jan 23 10:11:52 2009 +0100 Fix build on Solaris. Fixes bug #568480. Fix linking on Solaris by checking for the nsl and socket libraries which are needed for socket() and gethostbyname(). Don't initialize some fields of struct mh to NULL/0, they're already set to NULL/0 by a memset(). Also this fields don't exist on Solaris.