After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568480 - gst-plugins-bad dccp plugin won't compile on Soalris
gst-plugins-bad dccp plugin won't compile on Soalris
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other opensolaris
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-20 20:41 UTC by Brian Cameron
Modified: 2009-01-23 09:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
patch fixing dccp plugin so it builds (2.10 KB, patch)
2009-01-20 20:41 UTC, Brian Cameron
needs-work Details | Review
updated patch (726 bytes, patch)
2009-01-23 04:18 UTC, Brian Cameron
committed Details | Review

Description Brian Cameron 2009-01-20 20:41:17 UTC
On Solaris, there is no msg_control or msg_controllen is the msghdr struture.  The attached patch fixes gst-plugins-bad so it will build on Solaris.
Comment 1 Brian Cameron 2009-01-20 20:41:47 UTC
Created attachment 126864 [details] [review]
patch fixing dccp plugin so it builds
Comment 2 Sebastian Dröge (slomo) 2009-01-22 13:10:59 UTC
We need a configure check for those libraries as they're only available on Solaris. Also, instead of the configure check you added you could simply memset() the struct to 0 before using it instead of setting those fields in an #ifdef. The check is fine too though :)
Comment 3 Brian Cameron 2009-01-23 04:18:30 UTC
Created attachment 127059 [details] [review]
updated patch


Note the code already memsets the structure to 0, so the updated patch just removes the redundant places where the code was setting it to 0 again.
Comment 4 Sebastian Dröge (slomo) 2009-01-23 09:14:12 UTC
commit 486d76b4544ee9d2c4cf6ab5730f0f12c422a6d0
Author: Brian Cameron <brian.cameron@sun.com>
Date:   Fri Jan 23 10:11:52 2009 +0100

    Fix build on Solaris. Fixes bug #568480.
    
    Fix linking on Solaris by checking for the nsl and socket
    libraries which are needed for socket() and gethostbyname().
    
    Don't initialize some fields of struct mh to NULL/0, they're
    already set to NULL/0 by a memset(). Also this fields don't
    exist on Solaris.