After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568468 - gstgsmdec issue
gstgsmdec issue
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other opensolaris
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-20 18:55 UTC by Brian Cameron
Modified: 2009-01-20 20:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (502 bytes, patch)
2009-01-20 18:55 UTC, Brian Cameron 		none Details | Review

Description Brian Cameron 2009-01-20 18:55:00 UTC 
On Solaris we are applying the attached patch to gstgsmdec.  Should this go upstream?
Comment 1 Brian Cameron 2009-01-20 18:55:19 UTC 
Created attachment 126857 [details] [review]
patch
Comment 2 Brian Cameron 2009-01-20 18:58:53 UTC 
Looking at this patch, I'm guessing this is not right, and shouldn't be applied.  I'm not sure why this patch was added to our builds but I think we should be using the system byte order rather than hardcoding to a specific endianness, right?
Comment 3 Michael Smith 2009-01-20 19:02:42 UTC 
The patch is obviously wrong:
 - if the gsm decoder outputs big-endian always, then it needs changing in the template caps as well
 - if it outputs host-endian, then it's already doing the right thing.

I don't know what the gsm decoder actually does, so I don't know which of these options is correct - I suspect we don't need to change anything though.
Comment 4 Brian Cameron 2009-01-20 20:32:58 UTC 
Thanks for the heads up.  I removed this patch since it was clearly wrong.

Closing this bug.