After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568072 - nodetree.hg contains non-ASCII character cause warning C4819 in VS2008
nodetree.hg contains non-ASCII character cause warning C4819 in VS2008
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: general
2.18.x
Other All
: Normal trivial
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2009-01-17 12:14 UTC by Tao Wang
Modified: 2009-01-19 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (808 bytes, patch)
2009-01-17 12:20 UTC, Tao Wang 		none Details | Review

Description Tao Wang 2009-01-17 12:14:24 UTC 
Please describe the problem:
When compile the library, the warning C4819 on nodetree.h is always shown in Visual Studio 2008.


Steps to reproduce:
1. Just compile a small gtkmm demo program under non-English Windows system by Visual Studio 2008.


Actual results:
Visual Studio 2008 will raise the following warning:

c:\program files\gtkmm\include\glibmm-2.4\glibmm\nodetree.h : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss



Expected results:


Does this happen every time?
Yes

Other information:
Comment 1 Tao Wang 2009-01-17 12:20:34 UTC 
Created attachment 126642 [details] [review]
proposed patch

The problem is caused by a non-ASCII character '—' in comments of the nodetree.hg.

Fixed by replace it with '-'.
Comment 2 Murray Cumming 2009-01-19 09:02:10 UTC 
Thanks. I have committed that to the trunk and glibmm-2-18 branches.

Please remember to patch the ChangeLog in future.