After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567997 - [patch] add allow-pull-scheduling property to audio sinks
[patch] add allow-pull-scheduling property to audio sinks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.22
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 580626 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-01-16 17:12 UTC by Andy Wingo
Modified: 2009-05-26 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to -base (3.40 KB, patch)
2009-01-16 17:13 UTC, Andy Wingo
none Details | Review
same as before, but with property named can-activate-pull (3.37 KB, patch)
2009-01-19 11:26 UTC, Andy Wingo
none Details | Review
add can-activate-pull property to baseaudiosink (1.04 KB, patch)
2009-01-21 12:06 UTC, Andy Wingo
none Details | Review
add can-activate-pull property to baseaudiosink (2.48 KB, patch)
2009-01-21 12:12 UTC, Andy Wingo
none Details | Review
add can-activate-pull property to baseaudiosink (3.10 KB, patch)
2009-01-21 12:23 UTC, Andy Wingo
none Details | Review

Description Andy Wingo 2009-01-16 17:12:43 UTC
The attached patch allows pull-mode scheduling to be enabled by the user. Of course that should be the default when everything works, but if you want pull-mode scheduling before it's ready, this is a useful property.
Comment 1 Andy Wingo 2009-01-16 17:13:15 UTC
Created attachment 126594 [details] [review]
patch to -base
Comment 2 Wim Taymans 2009-01-16 18:01:33 UTC
can you rename it to can-activate-pull, to match the fakesink property.
Comment 3 Andy Wingo 2009-01-19 11:26:21 UTC
Created attachment 126748 [details] [review]
same as before, but with property named can-activate-pull
Comment 4 Andy Wingo 2009-01-21 12:06:42 UTC
Created attachment 126911 [details] [review]
add can-activate-pull property to baseaudiosink

* gst-libs/gst/audio/gstbaseaudiosink.c: Add can-activate-pull property
  to baseaudiosink.
Comment 5 Andy Wingo 2009-01-21 12:12:28 UTC
Created attachment 126912 [details] [review]
add can-activate-pull property to baseaudiosink

* gst-libs/gst/audio/gstbaseaudiosink.c: Add can-activate-pull property
  to baseaudiosink.
Comment 6 Andy Wingo 2009-01-21 12:23:24 UTC
Created attachment 126913 [details] [review]
add can-activate-pull property to baseaudiosink

* gst-libs/gst/audio/gstbaseaudiosink.c: Add can-activate-pull property
  to baseaudiosink.
Comment 7 Andy Wingo 2009-01-21 12:23:54 UTC
Sorry for the noise, I have a new tool and am spamming here...
Comment 8 Andy Wingo 2009-04-28 16:50:31 UTC
*** Bug 580626 has been marked as a duplicate of this bug. ***
Comment 9 Andy Wingo 2009-04-29 09:22:23 UTC
Reopening, as I shouldn't have committed during the freeze.
Comment 10 Andy Wingo 2009-05-26 11:31:46 UTC
And applied again!