GNOME Bugzilla – Bug 567965
[flvdemux] add support for ECMA arrays in script tags
Last modified: 2009-01-22 12:41:10 UTC
In CVS HEAD flvdemux does not recognize ECMA array objects in script tags. GST_DEBUG=flvdemux:2 gst-launch-0.10 filesrc location=charlie.indexed.flv ! flvdemux ! fakesink WARN flvdemux gstflvparse.c:316:gst_flv_parse_metadata_item:<flvdemux0> unsupported tag type 8 This for instance makes the file unseekable in totem. The attached patch adds support for such objects. If you want I can upload an example FLV to bugzilla.
Created attachment 126573 [details] [review] ECMA array support in script tags
BTW: you will notice the striking similarity between the code that parses Objects and the code that parses ECMA arrays. I kept them separated (i.e. copied the Object parsing code) for the sake of cleanliness.
Thanks, I'll commit this for 0.10.11 after 0.10.10 is released.
commit 62ac92210dee67570f514259e9cc3c1b32dd1c47 Author: Jan Urbanski <j.urbanski@students.mimuw.edu.pl> Date: Thu Jan 22 13:39:34 2009 +0100 Add support for ECMA arrays in script tags. Fixes bug #567965. Add support for ECMA arrays in script tags. This fixes seeking on some files that have the seek table stored inside an ECMA array instead of the normal array.