After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567965 - [flvdemux] add support for ECMA arrays in script tags
[flvdemux] add support for ECMA arrays in script tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-16 12:08 UTC by Jan Urbański
Modified: 2009-01-22 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ECMA array support in script tags (1.13 KB, patch)
2009-01-16 12:09 UTC, Jan Urbański 		committed Details | Review

Description Jan Urbański 2009-01-16 12:08:32 UTC 
In CVS HEAD flvdemux does not recognize ECMA array objects in script tags.

GST_DEBUG=flvdemux:2 gst-launch-0.10 filesrc location=charlie.indexed.flv ! flvdemux ! fakesink

WARN flvdemux gstflvparse.c:316:gst_flv_parse_metadata_item:<flvdemux0> unsupported tag type 8

This for instance makes the file unseekable in totem.

The attached patch adds support for such objects.

If you want I can upload an example FLV to bugzilla.
Comment 1 Jan Urbański 2009-01-16 12:09:26 UTC 
Created attachment 126573 [details] [review]
ECMA array support in script tags
Comment 2 Jan Urbański 2009-01-16 12:10:59 UTC 
BTW: you will notice the striking similarity between the code that parses Objects and the code that parses ECMA arrays. I kept them separated (i.e. copied the Object parsing code) for the sake of cleanliness.
Comment 3 Sebastian Dröge (slomo) 2009-01-16 13:12:15 UTC 
Thanks, I'll commit this for 0.10.11 after 0.10.10 is released.
Comment 4 Sebastian Dröge (slomo) 2009-01-22 12:41:10 UTC 
commit 62ac92210dee67570f514259e9cc3c1b32dd1c47
Author: Jan Urbanski <j.urbanski@students.mimuw.edu.pl>
Date:   Thu Jan 22 13:39:34 2009 +0100

    Add support for ECMA arrays in script tags. Fixes bug #567965.
    
    Add support for ECMA arrays in script tags. This fixes
    seeking on some files that have the seek table stored
    inside an ECMA array instead of the normal array.