Created attachment 126563 [details] [review]
Patch adds 8bit grayscale support to videocrop plugin

-  if (gst_structure_has_name (structure, "video/x-raw-rgb")) {
+  if (gst_structure_has_name (structure, "video/x-raw-rgb" ||
+      gst_structure_has_name (structure, "video/x-raw-gray"))) {
     gint bpp = 0;

There is a wrong backet there (need to close the first structure_has_name call)

commited with corrected brackets.

        Patch by: Luotao Fu <l dot fu at pengutronix dot de>

        * gst/videocrop/gstvideocrop.c:
        (gst_video_crop_get_image_details_from_caps):
        Add 8bit grayscale support to videocrop plugin. Fixes #567952.

Comment on attachment 126563 [details] [review]
Patch adds 8bit grayscale support to videocrop plugin

>From: Luotao Fu <l.fu@pengutronix.de>
>Subject: [PATCH] videocrop: add b/w support
>
>Adds 8bit grayscale support to videocrop plugin
>
>Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
>---
> gst/videocrop/gstvideocrop.c |   12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/gst/videocrop/gstvideocrop.c b/gst/videocrop/gstvideocrop.c
>index e4fcbd3..32ffb9d 100644
>--- a/gst/videocrop/gstvideocrop.c
>+++ b/gst/videocrop/gstvideocrop.c
>@@ -88,6 +88,12 @@ enum
> };
> 
> /* the formats we support */
>+#define GST_VIDEO_CAPS_GRAY "video/x-raw-gray, "			\
>+    "bpp = (int) 8, "                                                  \
>+    "width = " GST_VIDEO_SIZE_RANGE ", "                                \
>+    "height = " GST_VIDEO_SIZE_RANGE ", "                               \
>+    "framerate = " GST_VIDEO_FPS_RANGE
>+
> #define VIDEO_CROP_CAPS                          \
>   GST_VIDEO_CAPS_RGBx ";"                        \
>   GST_VIDEO_CAPS_xRGB ";"                        \
>@@ -107,7 +113,8 @@ enum
>   GST_VIDEO_CAPS_YUV ("I420") ";"                \
>   GST_VIDEO_CAPS_YUV ("YV12") ";"                \
>   GST_VIDEO_CAPS_RGB_16 ";"                      \
>-  GST_VIDEO_CAPS_RGB_15
>+  GST_VIDEO_CAPS_RGB_15 ";"			 \
>+  GST_VIDEO_CAPS_GRAY
> 
> static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src",
>     GST_PAD_SRC,
>@@ -211,7 +218,8 @@ gst_video_crop_get_image_details_from_caps (GstVideoCrop * vcrop,
>   details->width = width;
>   details->height = height;
> 
>-  if (gst_structure_has_name (structure, "video/x-raw-rgb")) {
>+  if (gst_structure_has_name (structure, "video/x-raw-rgb") ||
>+      gst_structure_has_name (structure, "video/x-raw-gray")) {
>     gint bpp = 0;
> 
>     if (!gst_structure_get_int (structure, "bpp", &bpp) || (bpp & 0x07) != 0)
>-- 
>1.5.6.5
>

(In reply to comment #3)
> commited with corrected brackets.
> 
>         Patch by: Luotao Fu <l dot fu at pengutronix dot de>
> 
>         * gst/videocrop/gstvideocrop.c:
>         (gst_video_crop_get_image_details_from_caps):
>         Add 8bit grayscale support to videocrop plugin. Fixes #567952.
> 

Oops, stupid mark/past error. Just for better record. fixed in my attachment
too.

Please ignore the comment above. 'd learn to use Bugzilla as well..... ;-)

cheers
Luotao