Created attachment 126510 [details] [review]
audiodelay.diff

Looks good at first glance, but haven't tried it yet. Random nitpi^Hthoughts when glancing over the code:

 - the name: is 'audiodelay' really the most fitting name
   (rather than, say, 'audioreverb')? Just wondering since
   'delay' could also be interpreted to mean that the timestamps
   etc. were tweaked.

 - might be good to add a 'Since' marker to the
   element gtk-doc blurb

 - maybe move code in set_property:PROP_DELAY to a helper func
   (somehow doesn't seem the right place to set up this stuff
   anyway)?

 - _get_property should take transform lock too, no? (get+set
   may theoretically be done concurrently from different
   threads)

 - bit sad that it's not enough to implement ::process(), but
   that's not really the element's fault I guess :)

I say put it in when/if you think it's ready.

Thanks, I've committed it as audioreverb now.

2009-01-19  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	* docs/plugins/Makefile.am:
	* docs/plugins/gst-plugins-good-plugins-docs.sgml:
	* docs/plugins/gst-plugins-good-plugins-sections.txt:
	* docs/plugins/gst-plugins-good-plugins.args:
	* docs/plugins/gst-plugins-good-plugins.hierarchy:
	* docs/plugins/inspect/plugin-audiofx.xml:
	* docs/plugins/inspect/plugin-spectrum.xml:
	* gst/audiofx/Makefile.am:
	* gst/audiofx/audiofx.c: (plugin_init):
	* gst/audiofx/audioreverb.c: (gst_audio_reverb_base_init),
	(gst_audio_reverb_class_init), (gst_audio_reverb_init),
	(gst_audio_reverb_finalize), (gst_audio_reverb_set_property),
	(gst_audio_reverb_get_property), (gst_audio_reverb_setup),
	(gst_audio_reverb_stop), (gst_audio_reverb_transform_ip):
	* gst/audiofx/audioreverb.h:
	* tests/check/Makefile.am:
	* tests/check/elements/audioreverb.c: (setup_reverb),
	(cleanup_reverb), (GST_START_TEST), (audioreverb_suite):
	Add an echo/reverb filter to the audiofx plugin, with configurable
	echo delay, intensity and feedback. Fixes bug #567874.