After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567697 - Plain text emails render links with ampersand characters stripped out
Plain text emails render links with ampersand characters stripped out
Status: RESOLVED OBSOLETE
Product: GtkHtml
Classification: Other
Component: Parsing
3.25.x
Other All
: Normal major
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
: 556456 (view as bug list)
Depends on:
Blocks: 681371
 
 
Reported: 2009-01-14 01:25 UTC by Peter Clifton
Modified: 2012-08-07 12:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Denis' patch from bug #552357 (3.44 KB, text/plain)
2009-01-23 12:06 UTC, Milan Crha
Details
Test email (1.10 KB, text/plain)
2009-01-26 14:32 UTC, Peter Clifton
Details

Description Peter Clifton 2009-01-14 01:25:52 UTC
Please describe the problem:
I've got many examples of emails on my system which contain http:// links with query strings in them, such as links to bugs etc..

When rendered the & characters are missing - although if you view the message source, they are present.

For example:

https://sourceforge.net/tracker/?func=detail&atid=818429&aid=2504418&group_id=161080

Gets rendered as:

https://sourceforge.net/tracker/?func=detailatid=818429aid=2504418group_id=161080

(And the clickable link is of course broken)

Steps to reproduce:
Email yourself a link with & in the query string

Actual results:
& is removed when rendered

Expected results:
& is not removed

Does this happen every time?
Yes (although I've only got plain text emails here to test with)

Other information:
Comment 1 Luca Foppiano 2009-01-19 08:25:28 UTC
I tried to reproduced on evolution 2.24.3, but it seems to work for me.

Can anyone try to do some tests?

Thanks
Luca
Comment 2 Christian Kirbach 2009-01-19 21:24:20 UTC
*** Bug 556456 has been marked as a duplicate of this bug. ***
Comment 3 Christian Kirbach 2009-01-19 21:25:49 UTC
This seems to be happenein on Evolution 2.22.2 so setting this version.
several people mailed bugmaster@gnome.org about this problem.
Comment 4 Bartlomiej Gerlich 2009-01-19 23:15:19 UTC
In message source I get a valid link, in rendered email I get a link with "&" removed. I'm using version 2.24.2, kernel 2.6.28, Ubuntu 9.04 alpha. 
Comment 5 Alexander Rice 2009-01-20 14:56:17 UTC
Confirmed with current SVN version of 2.25 branch : Evolution 2.25.5

Particularly irritating since it breaks the bugzilla subscribe URL...
Comment 6 Tomas Bzatek 2009-01-21 12:16:27 UTC
Confirming bug on evolution-2.25.4 and also on some old 2.24.2 ? (have to look at home).
Comment 7 Luca Foppiano 2009-01-21 12:57:11 UTC
In 2.24.3 I don't have this problem.. Can someone with this version give a try?

thanks
Luca
Comment 8 Milan Crha 2009-01-21 20:03:41 UTC
The actual trunk has this issue, but when reverting to version before a patch in bug #552357 (for GtkHTML), then it works as expected. Thus it should work fine even in 2.24.3. I tried to go back in GtkHTML to time of 2008-06-xx, and it works there fine for me too. I didn't try to move more back though.
Comment 9 Denis Pauk 2009-01-22 09:47:17 UTC
Please, someone test patch in bug #552357(process entity error solution) - may be resolve this bug.
Thanks.
Comment 10 Milan Crha 2009-01-23 12:06:12 UTC
Created attachment 127083 [details]
Denis' patch from bug #552357

Thanks for a quick response, Denis. I tested it and it fixed the issue with actual trunk. I'm going to commit it. Attaching patch here too, because it belongs here.
Comment 11 Milan Crha 2009-01-23 12:12:49 UTC
Committed to trunk. Committed revision 9115.

I saw also Evolution version 2.24.2, where this works fine. Thus it should be fixed there too. Please reopen when you think it isn't.
Comment 12 Peter Clifton 2009-01-24 19:31:27 UTC
Why are entities being expanded in plain text emails anyway?
Comment 13 Christian Kirbach 2009-01-25 19:47:31 UTC
Hi we get seeveral people a week mailing bugmaster@gnome.org because they were affected by stripped ampersands, thus having problems changing email addresses etc. 
Some of them are actually using Evolution 2.24.3 !

Milan it looks like you may need to fix 2.24.3, too.
Comment 14 Pavol Klačanský 2009-01-26 06:18:36 UTC
i have same problem in evolution 2.24.3
i cannot accept new e-mail, but i use webmail client

bugzilla confirm link
http://bugzilla.gnome.org/token.cgi?t=W5H5jxJ0Gc 
Comment 15 Milan Crha 2009-01-26 10:11:46 UTC
OK, I tried with actual sources from gnome-2-24 branch, stating 2.24.4 (not release yet) version, and I do not see that on my bugzilla mails with URLs containing ampersands, thus I suppose it's content dependant.

Can any user of 2.24.3 attach here a test message, with stripped confidential/private information, please, to give me some hints on reproducibility? Thanks in advance.

(And reopening bug for 2.24.3)
Comment 16 Peter Clifton 2009-01-26 14:32:10 UTC
Created attachment 127259 [details]
Test email
Comment 17 Peter Clifton 2009-01-26 14:32:59 UTC
Seriously though, arent &...; type entities a feature of HTML email?

Why are they even being processed for plain text mail?
Comment 18 Milan Crha 2009-01-26 16:23:44 UTC
Strange. I imported your test mail (thanks for it) to my local Inbox, and it shows correctly in 2.24.3 (evolution-data-server-2.24.3-1.fc10.i386, evolution-2.24.3-1.fc10.i386, gtkhtml3-3.24.3-1.fc10). I also tried to play with prefer-plain, but it doesn't seem to have any impact on a message preview under message list (with respect to amps there). It shows correctly in 2.25.6, which I hope is fine, but because I cannot reproduce even on yours 2.24.3, then I'm not as much sure.

(In reply to comment #17)
> Why are they even being processed for plain text mail?

That all is show in GtkHTML, which is naturally an HTML viewer/editor. There's either a bug about replacing '&' with '&' somewhere, or something similar. Hard to say at the moment, when I cannot reproduce it.

I hope I'm trying with correct versions, right?
Comment 19 Peter Clifton 2009-01-26 17:16:05 UTC
I'm running the development version of Ubuntu, Ubuntu Jaunty.

Evolution 2.24.3
Gnome is claiming 2.25.5

checking ldd `which evolution` | grep html:

	libgtkhtml-editor.so.0 => /usr/lib/libgtkhtml-editor.so.0 (0xb7d8c000)
	libgtkhtml-3.14.so.19 => /usr/lib/libgtkhtml-3.14.so.19 (0xb7683000)

dpkg-query -S /usr/lib/libgtkhtml-3.14.so.19.1.0 
libgtkhtml3.14-19: /usr/lib/libgtkhtml-3.14.so.19.1.0

dpkg-query -W libgtkhtml3.14-19
libgtkhtml3.14-19	1:3.25.5-0ubuntu1


I hope that information is of some help.
Comment 20 C de-Avillez 2009-01-26 22:50:08 UTC
Thanks Peter, it does indeed help. libgtkhtml3.14-19 was updated last week for Jaunty, to 1:3.25.5-0ubuntu1.

Milan's patch only made it to trunk on Jan 23rd, so... this issue is present on current Jaunty. This should get resolved on the next upgrade (probably to 2.25.90).

Previous version for this package is in intrepid-updates, 1:3.24.1.1-oubuntu1, which also seems to have the same bug.
Comment 21 C de-Avillez 2009-05-29 23:56:21 UTC
any news here? Does it work on 2.26.1?
Comment 22 Matthew Barnes 2009-05-30 01:51:41 UTC
It works correctly in 2.26.2 and 2.27.2.

Closing this as OBSOLETE.