After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567511 - colorkey in xvimagesink gets reset when element is reused
colorkey in xvimagesink gets reset when element is reused
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.22
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-12 15:46 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-01-13 06:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't reset the colorkey (873 bytes, patch)
2009-01-12 15:48 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		accepted-commit_now Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-12 15:46:42 UTC 
patch follows. Colorkey is a property, we should not change it internally.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-12 15:48:11 UTC 
Created attachment 126286 [details] [review]
don't reset the colorkey

There was also a ;; in the code which the patch removes along with the primary change.
Comment 2 Jan Schmidt 2009-01-12 17:14:19 UTC 
Looks ok, please commit.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-13 06:51:36 UTC 
2009-01-13  Stefan Kost  <ensonic@users.sf.net>

	* sys/xvimage/xvimagesink.c:
	  Don't reset the colorkey when element is reused. Fixes #567511.